public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools lvconvert.c Date: Tue, 13 Jul 2010 21:53:00 -0000 [thread overview] Message-ID: <20100713215308.19532.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2010-07-13 21:53:08 Modified files: tools : lvconvert.c Log message: Fix for bug 612311: Split of linear provides no error msg An unhandled condition allowed the command to terminate cleanly without a warning. Added a check for the '--splitmirrors' argument to allow execution to the lower level function that has the check to see if the user is trying to split a linear device. You should now see a message if you try to use --splitmirrors on a linear device. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvconvert.c.diff?cvsroot=lvm2&r1=1.138&r2=1.139 --- LVM2/tools/lvconvert.c 2010/07/09 15:34:48 1.138 +++ LVM2/tools/lvconvert.c 2010/07/13 21:53:07 1.139 @@ -861,7 +861,8 @@ else if (lp->mirrors_sign == SIGN_PLUS) lp->mirrors = *old_mimage_count + lp->mirrors; else if (lp->mirrors_sign == SIGN_MINUS) - lp->mirrors = *old_mimage_count - lp->mirrors; + lp->mirrors = (*old_mimage_count > lp->mirrors) ? + *old_mimage_count - lp->mirrors: 0; else lp->mirrors += 1; @@ -876,8 +877,8 @@ /* Did the user try to subtract more legs than available? */ if (lp->mirrors < 1) { - log_error("Logical volume %s only has %" PRIu32 " mirrors.", - lv->name, *old_mimage_count); + log_error("Unable to reduce images by specified amount - only %d in %s", + *old_mimage_count, lv->name); return 0; } @@ -1561,7 +1562,9 @@ stack; return ECMD_FAILED; } - } else if (arg_count(cmd, mirrors_ARG) || (lv->status & MIRRORED)) { + } else if (arg_count(cmd, mirrors_ARG) || + arg_count(cmd, splitmirrors_ARG) || + (lv->status & MIRRORED)) { if (!archive(lv->vg)) { stack; return ECMD_FAILED;
next reply other threads:[~2010-07-13 21:53 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-07-13 21:53 jbrassow [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-04-19 21:50 jbrassow 2012-02-23 22:36 zkabelac 2012-02-22 16:03 jbrassow 2012-02-22 15:20 jbrassow 2012-02-13 18:38 jbrassow 2012-02-13 18:36 jbrassow 2012-01-25 22:38 zkabelac 2011-12-08 18:00 agk 2011-06-29 2:06 jbrassow 2011-06-28 21:28 jbrassow 2011-01-19 19:24 jbrassow 2010-11-28 18:37 snitzer 2010-07-13 22:04 jbrassow 2010-07-01 10:10 mornfall 2010-06-23 20:32 jbrassow 2010-04-28 17:41 jbrassow 2010-04-26 18:12 agk 2010-04-20 12:18 agk 2010-03-31 20:39 agk 2010-02-05 22:47 snitzer 2010-01-13 1:49 snitzer 2010-01-13 1:47 snitzer 2010-01-11 17:13 jbrassow 2010-01-07 20:42 jbrassow 2009-10-21 22:19 jbrassow 2009-08-02 21:56 mornfall 2009-06-26 11:29 wysochanski 2009-06-10 15:27 mornfall 2009-05-19 10:27 mbroz 2009-05-19 10:12 mbroz 2008-01-16 22:54 agk 2008-01-16 19:40 agk 2008-01-16 19:16 agk 2007-12-21 1:08 agk 2007-08-01 20:54 jbrassow 2006-05-11 18:56 agk 2006-04-07 14:14 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100713215308.19532.qmail@sourceware.org \ --to=jbrassow@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).