public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: prajnoha@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/libdm/ioctl libdm-iface.c Date: Wed, 28 Jul 2010 10:30:00 -0000 [thread overview] Message-ID: <20100728103029.30900.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: prajnoha@sourceware.org 2010-07-28 10:30:29 Modified files: libdm/ioctl : libdm-iface.c Log message: Revert unsuccessful table load preparation in combined "create, load and resume" scenario. There was missing "revert" call in _create_and_load_v4 fn while the preparation for table load ends up with failure in create/load/resume sequence. Otherwise we could end up with a device being created, but not table-loaded nor resumed. Even though the table is not loaded and the device is not resumed at this stage, we still need to synchronize with udev when calling the revert "remove" ioctl - there's still a remove uevent generated! The "revert" code does exactly that. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/ioctl/libdm-iface.c.diff?cvsroot=lvm2&r1=1.76&r2=1.77 --- LVM2/libdm/ioctl/libdm-iface.c 2010/06/23 12:54:46 1.76 +++ LVM2/libdm/ioctl/libdm-iface.c 2010/07/28 10:30:28 1.77 @@ -1655,14 +1655,16 @@ if (!(task = dm_task_create(DM_DEVICE_RELOAD))) { log_error("Failed to create device-mapper task struct"); _udev_complete(dmt); - return 0; + r = 0; + goto revert; } /* Copy across relevant fields */ if (dmt->dev_name && !dm_task_set_name(task, dmt->dev_name)) { dm_task_destroy(task); _udev_complete(dmt); - return 0; + r = 0; + goto revert; } task->read_only = dmt->read_only;
next reply other threads:[~2010-07-28 10:30 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-07-28 10:30 prajnoha [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-05 14:45 prajnoha 2012-03-01 10:46 zkabelac 2011-11-08 19:02 snitzer 2011-10-17 14:36 zkabelac 2011-09-23 17:16 agk 2011-09-22 18:00 prajnoha 2011-08-19 16:49 agk 2011-06-29 16:08 agk 2011-06-29 11:36 agk 2011-06-29 8:54 agk 2011-06-13 3:53 agk 2011-03-20 2:00 agk 2011-03-05 21:17 mbroz 2011-03-02 8:41 zkabelac 2011-02-04 21:26 agk 2011-01-31 11:54 prajnoha 2010-11-30 22:32 zkabelac 2010-08-16 11:13 prajnoha 2010-05-03 22:08 prajnoha 2009-08-06 15:02 prajnoha
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100728103029.30900.qmail@sourceware.org \ --to=prajnoha@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).