public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/mirror.c tools/l ... Date: Mon, 02 Aug 2010 19:03:00 -0000 [thread overview] Message-ID: <20100802190347.28597.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2010-08-02 19:03:46 Modified files: . : WHATS_NEW lib/metadata : mirror.c tools : lvconvert.c Log message: Disallow mirrored logs in cluster mirrors. The cluster log daemon (cmirrord) is not multi-threaded and can handle only one request at a time. When a log is stacked on top of a mirror (which itself contains a 'core' log), it creates a situation that cannot be solved without threading. When the top level mirror issues a "resume", the log daemon attempts to read from the log device to retrieve the log state. However, the log is a mirror which, before issuing the read, attempts to determine the 'sync' status of the region of the mirror which is to be read. This sync status request cannot be completed by the daemon because it is blocked on a read I/O to the very mirror requesting the sync status. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1686&r2=1.1687 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.128&r2=1.129 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvconvert.c.diff?cvsroot=lvm2&r1=1.141&r2=1.142 --- LVM2/WHATS_NEW 2010/08/02 13:56:35 1.1686 +++ LVM2/WHATS_NEW 2010/08/02 19:03:45 1.1687 @@ -1,5 +1,6 @@ Version 2.02.73 - ================================ + Disallow 'mirrored' log type for cluster mirrors. Do not use VPATH in include/Makefile. Fix exported_symbols generation to use standard compiler arguments. Use #include <> not "" in lvm2app.h which gets installed on the system. --- LVM2/lib/metadata/mirror.c 2010/07/21 13:40:22 1.128 +++ LVM2/lib/metadata/mirror.c 2010/08/02 19:03:45 1.129 @@ -1970,10 +1970,21 @@ return 0; } - if (vg_is_clustered(lv->vg) && !(lv->status & ACTIVATE_EXCL) && - !cluster_mirror_is_available(lv)) { - log_error("Shared cluster mirrors are not available."); - return 0; + if (vg_is_clustered(lv->vg)) { + if (!(lv->status & ACTIVATE_EXCL) && + !cluster_mirror_is_available(lv)) { + log_error("Shared cluster mirrors are not available."); + return 0; + } + + /* + * No mirrored logs for cluster mirrors until + * log daemon is multi-threaded. + */ + if (log_count > 1) { + log_error("Log type, \"mirrored\", is unavailable to cluster mirrors"); + return 0; + } } /* For corelog mirror, activation code depends on --- LVM2/tools/lvconvert.c 2010/07/30 17:50:16 1.141 +++ LVM2/tools/lvconvert.c 2010/08/02 19:03:45 1.142 @@ -919,6 +919,15 @@ return 0; } + /* + * No mirrored logs for cluster mirrors until + * log daemon is multi-threaded. + */ + if ((*new_log_count == 2) && vg_is_clustered(lv->vg)) { + log_error("Log type, \"mirrored\", is unavailable to cluster mirrors"); + return 0; + } + log_verbose("Setting logging type to %s", mirrorlog); /*
next reply other threads:[~2010-08-02 19:03 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-02 19:03 jbrassow [this message] -- strict thread matches above, loose matches on Subject: below -- 2010-08-06 15:38 jbrassow 2010-08-02 21:07 jbrassow 2008-06-26 23:05 agk 2007-03-26 16:10 mbroz 2006-09-19 19:13 agk 2004-05-24 20:51 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100802190347.28597.qmail@sourceware.org \ --to=jbrassow@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).