public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: snitzer@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW test/t-snapshot-merge.sh tool ...
Date: Tue, 03 Aug 2010 20:22:00 -0000 [thread overview]
Message-ID: <20100803202232.16049.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: snitzer@sourceware.org 2010-08-03 20:22:32
Modified files:
. : WHATS_NEW
test : t-snapshot-merge.sh
tools : lvconvert.c
Log message:
Require logical volume(s) to be explicitly named for lvconvert --merge.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1694&r2=1.1695
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/t-snapshot-merge.sh.diff?cvsroot=lvm2&r1=1.6&r2=1.7
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvconvert.c.diff?cvsroot=lvm2&r1=1.143&r2=1.144
--- LVM2/WHATS_NEW 2010/08/03 18:19:43 1.1694
+++ LVM2/WHATS_NEW 2010/08/03 20:22:31 1.1695
@@ -1,5 +1,6 @@
Version 2.02.73 -
================================
+ Require logical volume(s) to be explicitly named for lvconvert --merge.
Avoid changing aligned pe_start as a side-effect of very verbose logging.
Fix 'void*' arithmetic warnings in dbg_malloc.c.
Fix 'void*' arithmetic warning in some functions from libdm-iface.c.
--- LVM2/test/t-snapshot-merge.sh 2010/04/23 19:27:11 1.6
+++ LVM2/test/t-snapshot-merge.sh 2010/08/03 20:22:31 1.7
@@ -49,6 +49,8 @@
# now that snapshot LV is created: test if snapshot-merge target is available
$(dmsetup targets | grep -q snapshot-merge) || exit 200
lvs -a
+# make sure lvconvert --merge requires explicit LV listing
+not lvconvert --merge 2>err
lvconvert --merge $vg/$(snap_lv_name_ $lv1)
lvremove -f $vg/$lv1
--- LVM2/tools/lvconvert.c 2010/08/02 21:07:41 1.143
+++ LVM2/tools/lvconvert.c 2010/08/03 20:22:31 1.144
@@ -1738,9 +1738,14 @@
return EINVALID_CMD_LINE;
}
- if (lp.merge)
+ if (lp.merge) {
+ if (!argc) {
+ log_error("Please provide logical volume path");
+ return EINVALID_CMD_LINE;
+ }
return process_each_lv(cmd, argc, argv, READ_FOR_UPDATE, &lp,
&lvconvert_merge_single);
+ }
return lvconvert_single(cmd, &lp);
}
reply other threads:[~2010-08-03 20:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100803202232.16049.qmail@sourceware.org \
--to=snitzer@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).