public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: prajnoha@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW_DM udev/10-dm.rules.in
Date: Thu, 12 Aug 2010 13:07:00 -0000	[thread overview]
Message-ID: <20100812130709.18389.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	prajnoha@sourceware.org	2010-08-12 13:07:08

Modified files:
	.              : WHATS_NEW_DM 
	udev           : 10-dm.rules.in 

Log message:
	Reinstate detection of inappropriate uevent with DISK_RO set and suppress it.
	
	We still need to detect this one! We're not so strict with CHANGE events as
	with the ADD events while applying filters in the rules so this one would
	pass and it would process the rules prematurely (because it appears *before*
	the actual CHANGE event used when resuming a DM device while setting read-only
	state at the same time).

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.405&r2=1.406
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/udev/10-dm.rules.in.diff?cvsroot=lvm2&r1=1.10&r2=1.11

--- LVM2/WHATS_NEW_DM	2010/08/11 13:12:31	1.405
+++ LVM2/WHATS_NEW_DM	2010/08/12 13:07:08	1.406
@@ -1,5 +1,6 @@
 Version 1.02.54 - 
 ================================
+  Reinstate detection of inappropriate uevent with DISK_RO set and suppress it.
   Fix segfault in regex matcher with characters of ordinal value > 127.
   Use built-in rule for device aliases: block/ < dm- < disk/ < mapper/ < other.
   Wait for node creation before displaying debug info in dmsetup.
--- LVM2/udev/10-dm.rules.in	2010/07/07 11:22:46	1.10
+++ LVM2/udev/10-dm.rules.in	2010/08/12 13:07:08	1.11
@@ -42,6 +42,9 @@
 # is not recommended.
 ACTION!="add|change", GOTO="dm_end"
 
+# Rule out easy-to-detect inappropriate events first.
+ENV{DISK_RO}=="1", GOTO="dm_disable"
+
 # There is no cookie set nor any flags encoded in events not originating
 # in libdevmapper so we need to detect this and try to behave correctly.
 # For such spurious events, regenerate all flags from current udev database content


             reply	other threads:[~2010-08-12 13:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-12 13:07 prajnoha [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-01-28 11:41 prajnoha
2010-08-12 13:41 prajnoha
2010-06-23 17:00 prajnoha
2009-12-07 12:03 prajnoha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100812130709.18389.qmail@sourceware.org \
    --to=prajnoha@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).