public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/mirror.c Date: Mon, 16 Aug 2010 18:02:00 -0000 [thread overview] Message-ID: <20100816180216.19180.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2010-08-16 18:02:15 Modified files: . : WHATS_NEW lib/metadata : mirror.c Log message: Fix for bug 612291: dm devices of split off mirror images are not removed DM devices were not handled properly on nodes in a cluster that were not where the splitmirrors command was issued. This was happening because suspend_lv/resume_lv were being used in a place where activate_lv should have been used. When the suspend/resume are issued on (effectively) new LVs, their 'resource' (UUID) is not located in the lv_hash. Thus, both operations turn into no-ops. You can see this from the output of clvmd from one of the remote nodes: <snip> do_suspend_lv, lock not already held <snip> do_resume_lv, lock not already held 'activate_lv' enjoins the other nodes in the cluster to process the lock and activate the new LV. clvmd output from remote node as follows: do_lock_lv: resource 'zMseY7CBuO3Ty09vXlplPAHzD0Y0CovjrTdv0R1VcwggMwPdYhutHErRcwm5Nd2S', cmd = 0x19 LCK_LV_ACTIVATE (READ|LV|NONBLOCK), flags = 0x84 (DMEVENTD_MONITOR ), memlock = 1 sync_lock: 'zMseY7CBuO3Ty09vXlplPAHzD0Y0CovjrTdv0R1VcwggMwPdYhutHErRcwm5Nd2S' mode:1 flags=1 sync_lock: returning lkid 27b0001 Signed-off-by: Jonathan Brassow <jbrassow@redhat.com> Reviewed-by: Petr Rockai <prockai@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1702&r2=1.1703 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.131&r2=1.132 --- LVM2/WHATS_NEW 2010/08/12 09:14:59 1.1702 +++ LVM2/WHATS_NEW 2010/08/16 18:02:14 1.1703 @@ -1,5 +1,6 @@ Version 2.02.73 - ================================ + Fix 'lvconvert --splitmirrors' in cluster operation. Fix clvmd init script exit code when executed as non-root user. Change default alignment of pe_start to 1MB. Add --norestorefile option to pvcreate. --- LVM2/lib/metadata/mirror.c 2010/08/06 15:38:32 1.131 +++ LVM2/lib/metadata/mirror.c 2010/08/16 18:02:14 1.132 @@ -719,19 +719,8 @@ return 0; } - /* - * Suspend the newly split-off LV (balance memlock count - * and prepare for DM automated renaming via resume). - */ - if (!suspend_lv(lv->vg->cmd, new_lv)) { - log_error("Failed to lock newly split LV, %s", new_lv->name); - vg_revert(lv->vg); - return 0; - } - /* Bring newly split-off LV into existence */ - log_very_verbose("Creating %s", new_lv->name); - if (!resume_lv(lv->vg->cmd, new_lv)) { + if (!activate_lv(lv->vg->cmd, new_lv)) { log_error("Failed to activate newly split LV, %s", new_lv->name); return 0;
next reply other threads:[~2010-08-16 18:02 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-16 18:02 jbrassow [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-23 16:28 mbroz 2012-02-01 13:50 zkabelac 2011-10-25 13:17 jbrassow 2011-10-06 14:49 jbrassow 2011-09-14 2:45 jbrassow 2011-09-13 21:13 jbrassow 2011-09-13 14:37 jbrassow 2011-09-13 13:59 jbrassow 2011-09-01 19:22 jbrassow 2011-06-17 14:27 zkabelac 2010-07-13 22:24 jbrassow 2010-07-13 21:48 jbrassow 2010-07-09 15:08 jbrassow 2010-06-28 14:19 jbrassow 2010-06-21 16:12 jbrassow 2010-04-27 15:27 jbrassow 2010-04-27 14:57 jbrassow 2009-12-09 19:53 mbroz 2009-12-09 18:09 mbroz 2009-04-10 9:53 mbroz 2008-10-17 10:50 agk 2008-09-18 19:09 agk 2008-06-13 12:15 meyering 2008-02-22 13:28 agk 2007-11-22 13:57 agk 2006-11-30 17:52 agk 2006-11-10 19:35 agk 2006-07-20 20:37 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100816180216.19180.qmail@sourceware.org \ --to=jbrassow@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).