From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25314 invoked by alias); 19 Aug 2010 23:04:38 -0000 Received: (qmail 25298 invoked by uid 9664); 19 Aug 2010 23:04:38 -0000 Date: Thu, 19 Aug 2010 23:04:00 -0000 Message-ID: <20100819230438.25296.qmail@sourceware.org> From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/pvremove.c tools/toollib.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00062.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2010-08-19 23:04:38 Modified files: . : WHATS_NEW tools : pvremove.c toollib.c Log message: Remove assumption that --yes must be used only in --force mode This is not only undocumented but is is also in violation with --help documentation. Using --yes without --force is useful in pvcreate when it detects old signature. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1713&r2=1.1714 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvremove.c.diff?cvsroot=lvm2&r1=1.28&r2=1.29 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.207&r2=1.208 --- LVM2/WHATS_NEW 2010/08/19 23:03:34 1.1713 +++ LVM2/WHATS_NEW 2010/08/19 23:04:37 1.1714 @@ -1,6 +1,7 @@ Version 2.02.74 - ================================== Simplify MD/swap signature detection in pvcreate and allow aborting. + Remove assumption that --yes must be used only in --force mode. Version 2.02.73 - 18th August 2010 ================================== --- LVM2/tools/pvremove.c 2010/07/09 15:34:48 1.28 +++ LVM2/tools/pvremove.c 2010/08/19 23:04:37 1.29 @@ -143,11 +143,6 @@ return EINVALID_CMD_LINE; } - if (arg_count(cmd, yes_ARG) && !arg_count(cmd, force_ARG)) { - log_error("Option y can only be given with option f"); - return EINVALID_CMD_LINE; - } - for (i = 0; i < argc; i++) { r = pvremove_single(cmd, argv[i], NULL); if (r > ret) --- LVM2/tools/toollib.c 2010/06/30 20:03:53 1.207 +++ LVM2/tools/toollib.c 2010/08/19 23:04:37 1.208 @@ -1344,11 +1344,6 @@ return 0; } - if (arg_count(cmd, yes_ARG) && !arg_count(cmd, force_ARG)) { - log_error("Option y can only be given with option f"); - return 0; - } - pp->yes = arg_count(cmd, yes_ARG); pp->force = arg_count(cmd, force_ARG);