public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/polldaemon.c tools/pvmove.c Date: Mon, 23 Aug 2010 11:34:00 -0000 [thread overview] Message-ID: <20100823113411.4981.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2010-08-23 11:34:10 Modified files: . : WHATS_NEW tools : polldaemon.c pvmove.c Log message: Fix pvmove --abort to work even for empty pvmove LV If pvmove crashed and metadata contains pvmove LV but without miorrored segments, pvmove --abort will not repair the situation (and finish wth success!). Fix it by allowing metadata update if aborting (thus removing pvmove LV) even if no moved LVs detected. (Tested on real metadata provided by an lvm user:-) Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1720&r2=1.1721 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/polldaemon.c.diff?cvsroot=lvm2&r1=1.34&r2=1.35 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvmove.c.diff?cvsroot=lvm2&r1=1.78&r2=1.79 --- LVM2/WHATS_NEW 2010/08/21 00:18:05 1.1720 +++ LVM2/WHATS_NEW 2010/08/23 11:34:10 1.1721 @@ -1,5 +1,6 @@ Version 2.02.74 - ================================== + Fix pvmove --abort to remove even for empty pvmove LV. Add configure --with-default-data-alignment. Update heuristic used for default and detected data alignment. Add "devices/default_data_alignment" to lvm.conf. --- LVM2/tools/polldaemon.c 2010/07/09 15:34:48 1.34 +++ LVM2/tools/polldaemon.c 2010/08/23 11:34:10 1.35 @@ -234,8 +234,10 @@ lv = lvl->lv; if (!(lv->status & parms->lv_type)) continue; - if (!(name = parms->poll_fns->get_copy_name_from_lv(lv))) + name = parms->poll_fns->get_copy_name_from_lv(lv); + if (!name && !parms->aborting) continue; + /* FIXME Need to do the activation from _set_up_pvmove here * if it's not running and we're not aborting */ if (_check_lv_status(cmd, vg, lv, name, parms, &finished) && --- LVM2/tools/pvmove.c 2010/07/09 15:34:48 1.78 +++ LVM2/tools/pvmove.c 2010/08/23 11:34:10 1.79 @@ -520,7 +520,8 @@ { int r = 1; - if (!_detach_pvmove_mirror(cmd, lv_mirr)) { + if (!dm_list_empty(lvs_changed) && + !_detach_pvmove_mirror(cmd, lv_mirr)) { log_error("ABORTING: Removal of temporary mirror failed"); return 0; }
reply other threads:[~2010-08-23 11:34 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100823113411.4981.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).