public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: mbroz@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW tools/polldaemon.c
Date: Mon, 23 Aug 2010 11:34:00 -0000 [thread overview]
Message-ID: <20100823113445.5215.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz@sourceware.org 2010-08-23 11:34:43
Modified files:
. : WHATS_NEW
tools : polldaemon.c
Log message:
Fix pvmove --abort <dev> return code
It prints error code even if abort operation succeeds:
pvmove --abort /dev/sdb
Command failed with status code 5.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1721&r2=1.1722
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/polldaemon.c.diff?cvsroot=lvm2&r1=1.35&r2=1.36
--- LVM2/WHATS_NEW 2010/08/23 11:34:10 1.1721
+++ LVM2/WHATS_NEW 2010/08/23 11:34:40 1.1722
@@ -1,5 +1,6 @@
Version 2.02.74 -
==================================
+ Fix return code of pvmove --abort PV.
Fix pvmove --abort to remove even for empty pvmove LV.
Add configure --with-default-data-alignment.
Update heuristic used for default and detected data alignment.
--- LVM2/tools/polldaemon.c 2010/08/23 11:34:10 1.35
+++ LVM2/tools/polldaemon.c 2010/08/23 11:34:41 1.36
@@ -120,8 +120,10 @@
"can't abort.");
return 0;
}
- parms->poll_fns->finish_copy(cmd, vg, lv, lvs_changed);
- return 0;
+ if (!parms->poll_fns->finish_copy(cmd, vg, lv, lvs_changed))
+ return_0;
+
+ return 1;
}
progress = parms->poll_fns->poll_progress(cmd, lv, name, parms);
next reply other threads:[~2010-08-23 11:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 11:34 mbroz [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-28 10:06 zkabelac
2011-01-19 23:11 mbroz
2011-01-05 12:59 zkabelac
2010-08-26 16:29 jbrassow
2009-09-30 17:43 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823113445.5215.qmail@sourceware.org \
--to=mbroz@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).