public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/activate/dev_manager.c Date: Thu, 26 Aug 2010 14:21:00 -0000 [thread overview] Message-ID: <20100826142153.7885.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2010-08-26 14:21:52 Modified files: . : WHATS_NEW lib/activate : dev_manager.c Log message: This patch fixes a potential for I/O to hang and LVM commands to block when a mirror under a snapshot suffers a failure. The problem has to do with label scanning. When a mirror suffers a failure, the kernel blocks I/O to prevent corruption. When LVM attempts to repair the mirror, it scans the devices on the system for LVM labels. While mirrors are skipped during this scanning process, snapshot-origins are not. When the origin is scanned, it kicks up I/O to the mirror (which is blocked) underneath - causing the label scan (an thus the repair operation) to hang. This patch simply bypasses snapshot-origin devices when doing labels scans (while ignore_suspended_devices() is set). This fixes the issue. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1724&r2=1.1725 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/dev_manager.c.diff?cvsroot=lvm2&r1=1.201&r2=1.202 --- LVM2/WHATS_NEW 2010/08/26 12:08:19 1.1724 +++ LVM2/WHATS_NEW 2010/08/26 14:21:50 1.1725 @@ -1,5 +1,6 @@ Version 2.02.74 - ================================== + Like mirrors, don't scan origins if ignore_suspended_devices() is set. Fix return type qualifier to avoid compiler warning. (2.02.69) Automatically generate LSB Requires-Start for clvmd init script. Fix return code of pvmove --abort PV. --- LVM2/lib/activate/dev_manager.c 2010/08/17 19:25:05 1.201 +++ LVM2/lib/activate/dev_manager.c 2010/08/26 14:21:51 1.202 @@ -175,6 +175,21 @@ log_debug("%s: Mirror device %s not usable.", dev_name(dev), name); goto out; } + + /* + * Snapshot origin could be sitting on top of a mirror which + * could be blocking I/O. Skip snapshot origins entirely for + * now. + * + * FIXME: rather than skipping origin, check if mirror is + * underneath and if the mirror is blocking I/O. + */ + if (target_type && !strcmp(target_type, "snapshot-origin") && + ignore_suspended_devices()) { + log_debug("%s: Snapshot-origin device %s not usable.", + dev_name(dev), name); + goto out; + } } while (next); /* FIXME Also check dependencies? */
next reply other threads:[~2010-08-26 14:21 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-26 14:21 jbrassow [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-16 12:50 agk 2012-04-20 14:17 jbrassow 2012-03-05 14:15 zkabelac 2012-02-01 13:47 zkabelac 2012-01-28 20:12 zkabelac 2012-01-23 20:56 jbrassow 2012-01-20 21:56 snitzer 2011-12-21 12:59 zkabelac 2011-11-18 19:42 zkabelac 2011-10-11 8:59 zkabelac 2011-10-11 8:57 zkabelac 2011-08-11 4:18 jbrassow 2011-07-06 0:29 agk 2011-07-05 23:10 agk 2011-01-05 14:03 zkabelac 2010-12-08 19:26 agk 2010-10-25 10:37 agk 2010-10-24 17:37 snitzer 2010-08-17 1:51 agk 2010-08-03 13:13 zkabelac 2010-05-24 9:01 zkabelac 2010-05-21 14:48 zkabelac 2010-02-08 23:28 snitzer 2010-01-26 7:58 mbroz 2010-01-22 15:40 snitzer 2009-08-03 18:09 agk 2009-05-28 1:11 agk 2009-05-13 14:13 zkabelac 2008-12-19 15:23 mbroz 2008-06-05 12:45 agk 2007-05-14 11:27 mbroz 2007-03-08 19:58 agk 2006-11-20 16:45 agk 2006-07-10 19:17 agk 2005-10-18 12:39 agk 2005-08-04 1:27 agk 2005-08-04 1:15 agk 2004-05-12 20:43 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100826142153.7885.qmail@sourceware.org \ --to=jbrassow@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).