public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW scripts/fsadm.sh Date: Fri, 08 Oct 2010 12:36:00 -0000 [thread overview] Message-ID: <20101008123601.29034.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2010-10-08 12:35:59 Modified files: . : WHATS_NEW scripts : fsadm.sh Log message: Fix a serious bug in the behavior of fasdm tool when breaked. Under certain conditions it was possible to break (^C) fsadm before actually resizing filesystem, but lvresize which executed fsadm will think resize was succesful and shrinks partitions with unresized filesystem on it. Fix by returning error (1) for this case - this stops lvresize from futher proceding in resize operation. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1747&r2=1.1748 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/scripts/fsadm.sh.diff?cvsroot=lvm2&r1=1.13&r2=1.14 --- LVM2/WHATS_NEW 2010/10/07 16:33:34 1.1747 +++ LVM2/WHATS_NEW 2010/10/08 12:35:56 1.1748 @@ -1,5 +1,6 @@ Version 2.02.75 - ===================================== + Fix fsadm return error code from user's break action. Allow CC to be overridden at build time (for 'scan-build make'). Rename 'flags' to 'status' in struct metadata_area. Avoid segfault by limiting partial mode for lvm1 metadata. (2.02.74) --- LVM2/scripts/fsadm.sh 2010/10/08 11:18:29 1.13 +++ LVM2/scripts/fsadm.sh 2010/10/08 12:35:59 1.14 @@ -1,6 +1,6 @@ #!/bin/bash # -# Copyright (C) 2007-2009 Red Hat, Inc. All rights reserved. +# Copyright (C) 2007-2010 Red Hat, Inc. All rights reserved. # # This file is part of LVM2. # @@ -129,7 +129,8 @@ # and allow recursive call of fsadm unset FSADM_RUNNING test "$DO_LVRESIZE" -eq 2 && exec $LVM lvresize $VERB -r -L$(( $NEWSIZE / 1048576 )) $VOLUME - exit ${1:-0} + # error exit status for break + exit ${1:-1} } # convert parameter from Exa/Peta/Tera/Giga/Mega/Kilo/Bytes and blocks
next reply other threads:[~2010-10-08 12:36 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-10-08 12:36 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-16 12:53 zkabelac 2011-09-19 14:52 zkabelac 2011-09-19 13:51 zkabelac 2011-09-19 13:47 zkabelac 2011-09-19 13:43 zkabelac 2010-11-10 16:14 zkabelac 2010-11-01 14:08 zkabelac 2010-10-08 15:02 zkabelac 2010-10-08 15:00 zkabelac 2010-10-08 14:55 zkabelac 2010-10-08 14:49 zkabelac 2010-10-08 13:49 zkabelac 2010-10-08 13:47 zkabelac 2009-06-09 15:31 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101008123601.29034.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).