public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW scripts/fsadm.sh Date: Fri, 08 Oct 2010 13:47:00 -0000 [thread overview] Message-ID: <20101008134712.1803.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2010-10-08 13:47:11 Modified files: . : WHATS_NEW scripts : fsadm.sh Log message: Correctly respect --dry-run option for fsadm Fix missing 'dry' execution of lvresize - fixing problem where resize command were 'dry-run' executed - but lvresize has been executed for real. Also adapt code slightly to support better recursive execution of fsadm through lvresize call. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1748&r2=1.1749 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/scripts/fsadm.sh.diff?cvsroot=lvm2&r1=1.14&r2=1.15 --- LVM2/WHATS_NEW 2010/10/08 12:35:56 1.1748 +++ LVM2/WHATS_NEW 2010/10/08 13:47:10 1.1749 @@ -1,5 +1,6 @@ Version 2.02.75 - ===================================== + Do not execute lvresize with --dry-run option for fsadm. Fix fsadm return error code from user's break action. Allow CC to be overridden at build time (for 'scan-build make'). Rename 'flags' to 'status' in struct metadata_area. --- LVM2/scripts/fsadm.sh 2010/10/08 12:35:59 1.14 +++ LVM2/scripts/fsadm.sh 2010/10/08 13:47:10 1.15 @@ -125,10 +125,13 @@ IFS=$IFS_OLD trap 2 - # start LVRESIZE with the filesystem modification flag - # and allow recursive call of fsadm - unset FSADM_RUNNING - test "$DO_LVRESIZE" -eq 2 && exec $LVM lvresize $VERB -r -L$(( $NEWSIZE / 1048576 )) $VOLUME + if [ "$DO_LVRESIZE" -eq 2 ]; then + # start LVRESIZE with the filesystem modification flag + # and allow recursive call of fsadm + unset FSADM_RUNNING + dry exec $LVM lvresize $VERB $FORCE -r -L${NEWSIZE}b $VOLUME_ORIG + fi + # error exit status for break exit ${1:-1} }
next reply other threads:[~2010-10-08 13:47 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-10-08 13:47 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-16 12:53 zkabelac 2011-09-19 14:52 zkabelac 2011-09-19 13:51 zkabelac 2011-09-19 13:47 zkabelac 2011-09-19 13:43 zkabelac 2010-11-10 16:14 zkabelac 2010-11-01 14:08 zkabelac 2010-10-08 15:02 zkabelac 2010-10-08 15:00 zkabelac 2010-10-08 14:55 zkabelac 2010-10-08 14:49 zkabelac 2010-10-08 13:49 zkabelac 2010-10-08 12:36 zkabelac 2009-06-09 15:31 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101008134712.1803.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).