public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: wysochanski@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/lib metadata/lv.c metadata/lv.h report/pr ...
Date: Tue, 12 Oct 2010 16:11:00 -0000 [thread overview]
Message-ID: <20101012161149.23554.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski@sourceware.org 2010-10-12 16:11:48
Modified files:
lib/metadata : lv.c lv.h
lib/report : properties.c report.c
Log message:
Refactor and add code for (lv) 'origin_size' get function.
Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
Reviewed-By: Petr Rockai <prockai@redhat.com>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/lv.c.diff?cvsroot=lvm2&r1=1.7&r2=1.8
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/lv.h.diff?cvsroot=lvm2&r1=1.6&r2=1.7
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/report/properties.c.diff?cvsroot=lvm2&r1=1.10&r2=1.11
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/report/report.c.diff?cvsroot=lvm2&r1=1.132&r2=1.133
--- LVM2/lib/metadata/lv.c 2010/10/12 16:11:34 1.7
+++ LVM2/lib/metadata/lv.c 2010/10/12 16:11:48 1.8
@@ -18,6 +18,15 @@
#include "activate.h"
#include "toolcontext.h"
+uint64_t lv_origin_size(const struct logical_volume *lv)
+{
+ if (lv_is_cow(lv))
+ return (uint64_t) find_cow(lv)->len * lv->vg->extent_size;
+ if (lv_is_origin(lv))
+ return lv->size;
+ return 0;
+}
+
char *lv_path_dup(struct dm_pool *mem, const struct logical_volume *lv)
{
char *repstr;
--- LVM2/lib/metadata/lv.h 2010/10/12 16:11:34 1.6
+++ LVM2/lib/metadata/lv.h 2010/10/12 16:11:48 1.7
@@ -53,5 +53,6 @@
char *lv_uuid_dup(const struct logical_volume *lv);
char *lv_tags_dup(const struct logical_volume *lv);
char *lv_path_dup(struct dm_pool *mem, const struct logical_volume *lv);
+uint64_t lv_origin_size(const struct logical_volume *lv);
#endif
--- LVM2/lib/report/properties.c 2010/10/12 16:11:34 1.10
+++ LVM2/lib/report/properties.c 2010/10/12 16:11:48 1.11
@@ -123,7 +123,7 @@
#define _seg_count_set _not_implemented_set
#define _origin_get _not_implemented_get
#define _origin_set _not_implemented_set
-#define _origin_size_get _not_implemented_get
+GET_LV_NUM_PROPERTY_FN(origin_size, lv_origin_size(lv))
#define _origin_size_set _not_implemented_set
#define _snap_percent_get _not_implemented_get
#define _snap_percent_set _not_implemented_set
--- LVM2/lib/report/report.c 2010/10/12 16:11:34 1.132
+++ LVM2/lib/report/report.c 2010/10/12 16:11:48 1.133
@@ -570,12 +570,7 @@
const struct logical_volume *lv = (const struct logical_volume *) data;
uint64_t size;
- if (lv_is_cow(lv))
- size = (uint64_t) find_cow(lv)->len * lv->vg->extent_size;
- else if (lv_is_origin(lv))
- size = lv->size;
- else
- size = UINT64_C(0);
+ size = lv_origin_size(lv);
return _size64_disp(rh, mem, field, &size, private);
}
next reply other threads:[~2010-10-12 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 16:11 wysochanski [this message]
2010-10-12 16:11 wysochanski
2010-10-12 16:12 wysochanski
2010-10-12 16:12 wysochanski
2010-10-12 16:12 wysochanski
2010-10-12 16:12 wysochanski
2010-10-12 16:13 wysochanski
2010-10-21 14:49 wysochanski
2010-10-21 14:49 wysochanski
2010-10-21 14:49 wysochanski
2010-11-17 20:08 mornfall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012161149.23554.qmail@sourceware.org \
--to=wysochanski@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).