public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 lib/device/device.c ./WHATS_NEW
Date: Wed, 20 Oct 2010 15:07:00 -0000 [thread overview]
Message-ID: <20101020150732.5923.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2010-10-20 15:07:31
Modified files:
lib/device : device.c
. : WHATS_NEW
Log message:
Fix strict-aliasing compile warning in partition table scanning
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/device/device.c.diff?cvsroot=lvm2&r1=1.34&r2=1.35
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1764&r2=1.1765
--- LVM2/lib/device/device.c 2010/08/11 12:14:24 1.34
+++ LVM2/lib/device/device.c 2010/10/20 15:07:30 1.35
@@ -58,9 +58,11 @@
{
int ret = 0;
unsigned p;
- uint16_t buf[SECTOR_SIZE/sizeof(uint16_t)];
- uint16_t *part_magic;
- struct partition *part;
+ struct {
+ uint8_t skip[PART_OFFSET];
+ struct partition part[4];
+ uint16_t magic;
+ } __attribute__((packed)) buf; /* sizeof() == SECTOR_SIZE */
if (!dev_read(dev, UINT64_C(0), sizeof(buf), &buf))
return_0;
@@ -68,17 +70,15 @@
/* FIXME Check for other types of partition table too */
/* Check for msdos partition table */
- part_magic = buf + PART_MAGIC_OFFSET/sizeof(buf[0]);
- if ((*part_magic == xlate16(PART_MAGIC))) {
- part = (struct partition *) (buf + PART_OFFSET/sizeof(buf[0]));
- for (p = 0; p < 4; p++, part++) {
+ if (buf.magic == xlate16(PART_MAGIC)) {
+ for (p = 0; p < 4; ++p) {
/* Table is invalid if boot indicator not 0 or 0x80 */
- if ((part->boot_ind & 0x7f)) {
+ if (buf.part[p].boot_ind & 0x7f) {
ret = 0;
break;
}
/* Must have at least one non-empty partition */
- if (part->nr_sects)
+ if (buf.part[p].nr_sects)
ret = 1;
}
}
--- LVM2/WHATS_NEW 2010/10/15 17:04:02 1.1764
+++ LVM2/WHATS_NEW 2010/10/20 15:07:30 1.1765
@@ -1,5 +1,6 @@
Version 2.02.75 -
=====================================
+ Fix strict-aliasing compile warning in partition table scanning.
Add an option to automatically extend snapshots through dmeventd.
Remove dependency on libm, floor() is replaced with integer algorithm.
Fix hang when repairing a mirrored-log that had both devs fail.
reply other threads:[~2010-10-20 15:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020150732.5923.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).