public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/pvresize.c Date: Mon, 25 Oct 2010 12:01:00 -0000 [thread overview] Message-ID: <20101025120139.5490.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2010-10-25 12:01:38 Modified files: . : WHATS_NEW tools : pvresize.c Log message: Print vg_name and do not to access vg->name Reported by clang as: Logic error Dereference of null pointer Replace pointer dereference with vg_name. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1770&r2=1.1771 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvresize.c.diff?cvsroot=lvm2&r1=1.35&r2=1.36 --- LVM2/WHATS_NEW 2010/10/25 11:57:06 1.1770 +++ LVM2/WHATS_NEW 2010/10/25 12:01:38 1.1771 @@ -1,5 +1,6 @@ Version 2.02.75 - ===================================== + Fix pointer for VG name in _pv_resize_single error code path. Fix warning for changed alignment requirements for dmeventd read/write func. Add global/metadata_read_only to use unrepaired metadata in read-only cmds. Don't take write lock in vgchange --refresh, --poll or --monitor. --- LVM2/tools/pvresize.c 2010/05/19 01:16:41 1.35 +++ LVM2/tools/pvresize.c 2010/10/25 12:01:38 1.36 @@ -148,7 +148,7 @@ if (!is_orphan_vg(vg_name)) { if (!vg_write(vg) || !vg_commit(vg)) { log_error("Failed to store physical volume \"%s\" in " - "volume group \"%s\"", pv_name, vg->name); + "volume group \"%s\"", pv_name, vg_name); goto out; } backup(vg);
next reply other threads:[~2010-10-25 12:01 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-10-25 12:01 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2008-09-12 15:26 mbroz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101025120139.5490.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).