public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: wysochanski@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/lib/report properties.c properties.h
Date: Mon, 25 Oct 2010 14:08:00 -0000 [thread overview]
Message-ID: <20101025140833.20168.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski@sourceware.org 2010-10-25 14:08:32
Modified files:
lib/report : properties.c properties.h
Log message:
Add 'is_integer' flag into internal lvm_property_type.
Add 'is_integer' flag similar to 'is_string'.
Suggested in review by Petr Rockai.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/report/properties.c.diff?cvsroot=lvm2&r1=1.21&r2=1.22
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/report/properties.h.diff?cvsroot=lvm2&r1=1.4&r2=1.5
--- LVM2/lib/report/properties.c 2010/10/21 18:51:16 1.21
+++ LVM2/lib/report/properties.c 2010/10/25 14:08:32 1.22
@@ -227,11 +227,11 @@
#define STR DM_REPORT_FIELD_TYPE_STRING
#define NUM DM_REPORT_FIELD_TYPE_NUMBER
#define FIELD(type, strct, sorttype, head, field, width, fn, id, desc, settable) \
- { type, #id, settable, sorttype == STR, { .integer = 0 }, _ ## id ## _get, _ ## id ## _set },
+ { type, #id, settable, sorttype == STR, sorttype == NUM, { .integer = 0 }, _ ## id ## _get, _ ## id ## _set },
struct lvm_property_type _properties[] = {
#include "columns.h"
- { 0, "", 0, 0, { .integer = 0 }, _not_implemented_get, _not_implemented_set },
+ { 0, "", 0, 0, 0, { .integer = 0 }, _not_implemented_get, _not_implemented_set },
};
#undef STR
--- LVM2/lib/report/properties.h 2010/10/21 18:51:17 1.4
+++ LVM2/lib/report/properties.h 2010/10/25 14:08:32 1.5
@@ -24,6 +24,7 @@
const char *id;
unsigned is_settable:1;
unsigned is_string:1;
+ unsigned is_integer:1;
union {
char *string;
uint64_t integer;
next reply other threads:[~2010-10-25 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 14:08 wysochanski [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-17 20:11 mornfall
2010-10-21 18:51 wysochanski
2010-10-21 14:49 wysochanski
2010-09-30 14:09 wysochanski
2010-08-20 12:44 wysochanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025140833.20168.qmail@sourceware.org \
--to=wysochanski@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).