public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/daemons/cmirrord functions.c Date: Tue, 26 Oct 2010 10:14:00 -0000 [thread overview] Message-ID: <20101026101442.23189.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2010-10-26 10:14:41 Modified files: daemons/cmirrord: functions.c Log message: Add missing return for NULL passed buffer Function pull_stateo() checks for NULL 'buf' - but return for this error path was missing. cmirror code never calls this function with NULL 'buf', so this fix has no effect on current code base, but makes clang happier. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/cmirrord/functions.c.diff?cvsroot=lvm2&r1=1.24&r2=1.25 --- LVM2/daemons/cmirrord/functions.c 2010/08/30 18:37:42 1.24 +++ LVM2/daemons/cmirrord/functions.c 2010/10/26 10:14:41 1.25 @@ -1809,8 +1809,10 @@ int bitset_size; struct log_c *lc; - if (!buf) + if (!buf) { LOG_ERROR("pull_state: buf == NULL"); + return -EINVAL; + } lc = get_log(uuid, luid); if (!lc) {
next reply other threads:[~2010-10-26 10:14 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-10-26 10:14 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2010-12-20 13:58 zkabelac 2010-06-21 16:07 jbrassow 2010-01-22 0:43 agk 2010-01-19 18:21 agk 2010-01-19 17:24 agk 2010-01-15 16:03 jbrassow
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101026101442.23189.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).