public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mornfall@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools reporter.c Date: Wed, 17 Nov 2010 22:26:00 -0000 [thread overview] Message-ID: <20101117222643.16641.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mornfall@sourceware.org 2010-11-17 22:26:43 Modified files: tools : reporter.c Log message: The _free_vg that is created as a placeholder when reporting segments in pvs was lacking the (vgmem) pool. We now create that pool. There is at least one more such VG (_dummy_vg) which is pool-less. I am not sure what is the right way to go about this, but this is currently necessary to fix a segfault introduced by using vgmem in the reporter in Dave's lvseg lvm2app patches. Signed-off-by: Petr Rockai <prockai@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/reporter.c.diff?cvsroot=lvm2&r1=1.62&r2=1.63 --- LVM2/tools/reporter.c 2010/07/09 15:34:48 1.62 +++ LVM2/tools/reporter.c 2010/11/17 22:26:42 1.63 @@ -64,6 +64,9 @@ .name = (char *)"", }; + if (!(_free_vg.vgmem = dm_pool_create("_free_vg", 10240))) + return ECMD_FAILED; + struct logical_volume _free_logical_volume = { .vg = vg ?: &_free_vg, .name = (char *) "", @@ -103,10 +106,11 @@ if (!report_object(handle, vg, seg ? seg->lv : &_free_logical_volume, pvseg->pv, seg ? : &_free_lv_segment, pvseg)) { - stack; ret = ECMD_FAILED; + goto_out; } - + out: + dm_pool_destroy(_free_vg.vgmem); return ret; }
next reply other threads:[~2010-11-17 22:26 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-11-17 22:26 mornfall [this message] -- strict thread matches above, loose matches on Subject: below -- 2010-04-23 19:10 snitzer 2009-01-10 17:21 agk 2007-01-27 2:32 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101117222643.16641.qmail@sourceware.org \ --to=mornfall@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).