public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/daemons/clvmd lvm-functions.c
Date: Mon, 29 Nov 2010 11:05:00 -0000	[thread overview]
Message-ID: <20101129110515.8572.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2010-11-29 11:05:15

Modified files:
	daemons/clvmd  : lvm-functions.c 

Log message:
	Remove printing of LCK_CACHE
	
	LCK_CACHE is defined as 0x100 so it cannot be passed through
	unsigned char parameter - remove it from the sprintf code.
	
	If the LCK_CLUSTER should be printed here - lot of code need
	to be reworked - so adding FIXME comment.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/lvm-functions.c.diff?cvsroot=lvm2&r1=1.100&r2=1.101

--- LVM2/daemons/clvmd/lvm-functions.c	2010/11/23 01:55:58	1.100
+++ LVM2/daemons/clvmd/lvm-functions.c	2010/11/29 11:05:15	1.101
@@ -44,6 +44,10 @@
 	int lock_mode;
 };
 
+/*
+ * FIXME: 8bit value passed here -
+ *        so only LCK_XXX defines < 0x100 can be decoded
+ */
 static const char *decode_locking_cmd(unsigned char cmdl)
 {
 	static char buf[128];
@@ -109,12 +113,11 @@
 		break;
 	}
 
-	sprintf(buf, "0x%x %s (%s|%s%s%s%s%s%s)", cmdl, command, type, scope,
+	sprintf(buf, "0x%x %s (%s|%s%s%s%s%s)", cmdl, command, type, scope,
 		cmdl & LCK_NONBLOCK   ? "|NONBLOCK" : "",
 		cmdl & LCK_HOLD       ? "|HOLD" : "",
 		cmdl & LCK_LOCAL      ? "|LOCAL" : "",
-		cmdl & LCK_CLUSTER_VG ? "|CLUSTER_VG" : "",
-		cmdl & LCK_CACHE      ? "|CACHE" : "");
+		cmdl & LCK_CLUSTER_VG ? "|CLUSTER_VG" : "");
 
 	return buf;
 }


             reply	other threads:[~2010-11-29 11:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-29 11:05 zkabelac [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-03-01 22:55 zkabelac
2012-03-01 21:18 zkabelac
2010-06-30 21:40 mornfall
2009-12-09 19:30 mbroz
2008-06-06 16:37 agk
2007-11-14 13:37 pcaulfield
2007-08-23 12:44 pcaulfield
2006-10-24 18:49 jbrassow
2006-10-06 10:06 pcaulfield
2006-08-22  9:49 pcaulfield
2006-05-15 12:32 pcaulfield
2006-05-15 11:56 agk
2004-09-22 12:10 pcaulfield
2004-06-28 10:26 pcaulfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101129110515.8572.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).