public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW libdm/ioctl/libdm-iface.c
Date: Tue, 30 Nov 2010 22:40:00 -0000 [thread overview]
Message-ID: <20101130224022.26776.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2010-11-30 22:40:20
Modified files:
. : WHATS_NEW
libdm/ioctl : libdm-iface.c
Log message:
Add stack trace for error path
If dm_task_set_cookie() fails print stack trace, but keep going on.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1817&r2=1.1818
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/ioctl/libdm-iface.c.diff?cvsroot=lvm2&r1=1.84&r2=1.85
--- LVM2/WHATS_NEW 2010/11/30 22:23:35 1.1817
+++ LVM2/WHATS_NEW 2010/11/30 22:40:19 1.1818
@@ -1,5 +1,6 @@
Version 2.02.78 -
====================================
+ Add error path stack traces for _process_mapper_dir(), _create_and_load_v4().
Add missing test for failed pool allocation in write_config_node().
Replace snprintf with dm_snprintf in clvmd-command.c.
Check reallocated buffer for NULL before use in clvmd do_command().
--- LVM2/libdm/ioctl/libdm-iface.c 2010/11/30 22:32:44 1.84
+++ LVM2/libdm/ioctl/libdm-iface.c 2010/11/30 22:40:20 1.85
@@ -1779,9 +1779,10 @@
if (dmt->cookie_set) {
cookie = (dmt->event_nr & ~DM_UDEV_FLAGS_MASK) |
(DM_COOKIE_MAGIC << DM_UDEV_FLAGS_SHIFT);
- dm_task_set_cookie(dmt, &cookie,
- (dmt->event_nr & DM_UDEV_FLAGS_MASK) >>
- DM_UDEV_FLAGS_SHIFT);
+ if (!dm_task_set_cookie(dmt, &cookie,
+ (dmt->event_nr & DM_UDEV_FLAGS_MASK) >>
+ DM_UDEV_FLAGS_SHIFT))
+ stack; /* keep going */
}
if (!dm_task_run(dmt))
next reply other threads:[~2010-11-30 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 22:40 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-08-03 13:16 zkabelac
2010-06-23 12:54 zkabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130224022.26776.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).