public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools lvmcmdline.c Date: Mon, 20 Dec 2010 13:16:00 -0000 [thread overview] Message-ID: <20101220131631.11350.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2010-12-20 13:16:30 Modified files: tools : lvmcmdline.c Log message: Test return value from read() and close() for an error. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvmcmdline.c.diff?cvsroot=lvm2&r1=1.134&r2=1.135 --- LVM2/tools/lvmcmdline.c 2010/11/30 11:53:33 1.134 +++ LVM2/tools/lvmcmdline.c 2010/12/20 13:16:30 1.135 @@ -1191,15 +1191,19 @@ { static char _proc_cmdline[32]; char buf[256]; - int fd; + int fd, n = 0; snprintf(buf, sizeof(buf), DEFAULT_PROC_DIR "/%u/cmdline", pid); + /* FIXME Use generic read code. */ if ((fd = open(buf, O_RDONLY)) > 0) { - read(fd, _proc_cmdline, sizeof(_proc_cmdline) - 1); - _proc_cmdline[sizeof(_proc_cmdline) - 1] = '\0'; - close(fd); - } else - _proc_cmdline[0] = '\0'; + if ((n = read(fd, _proc_cmdline, sizeof(_proc_cmdline) - 1)) < 0) { + log_sys_error("read", buf); + n = 0; + } + if (close(fd)) + log_sys_error("close", buf); + } + _proc_cmdline[n] = '\0'; return _proc_cmdline; }
next reply other threads:[~2010-12-20 13:16 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-12-20 13:16 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-04-11 12:49 agk 2012-03-01 21:17 zkabelac 2012-02-13 12:07 zkabelac 2011-08-04 14:54 zkabelac 2011-08-04 14:11 zkabelac 2011-04-22 12:07 prajnoha 2011-01-13 15:00 zkabelac 2010-12-20 13:59 zkabelac 2010-11-29 11:14 zkabelac 2010-04-30 13:47 prajnoha 2010-04-30 13:28 prajnoha 2010-03-23 15:13 prajnoha 2010-01-21 13:41 zkabelac 2009-07-27 21:01 wysochanski 2009-07-07 1:51 wysochanski 2009-04-02 14:59 mbroz 2008-12-11 3:34 wysochanski 2008-12-11 3:31 wysochanski 2008-12-11 3:28 wysochanski 2008-11-18 10:13 zkabelac 2008-11-12 9:49 zkabelac 2008-09-19 7:11 agk 2007-09-21 18:43 meyering 2004-11-12 15:58 agk 2004-06-29 13:27 agk 2004-04-05 16:24 agk 2004-03-26 12:21 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101220131631.11350.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).