From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24409 invoked by alias); 20 Dec 2010 14:08:47 -0000 Received: (qmail 24391 invoked by uid 9737); 20 Dec 2010 14:08:46 -0000 Date: Mon, 20 Dec 2010 14:08:00 -0000 Message-ID: <20101220140846.24389.qmail@sourceware.org> From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW daemons/dmeventd/dmeventd.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00057.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2010-12-20 14:08:46 Modified files: . : WHATS_NEW daemons/dmeventd: dmeventd.c Log message: Add check for unlink errors Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1846&r2=1.1847 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/dmeventd.c.diff?cvsroot=lvm2&r1=1.72&r2=1.73 --- LVM2/WHATS_NEW 2010/12/20 13:57:19 1.1846 +++ LVM2/WHATS_NEW 2010/12/20 14:08:46 1.1847 @@ -1,5 +1,6 @@ Version 2.02.79 - =================================== + Add check for unlink error result in remove_lockfile() (dmeventd). Use dm_free for dm_malloc-ed areas in _clog_ctr/_clog_dtr (cmirrord). Add checks for allocation errors in config node clonning. Fix error path if regex engine cannot be created in _build_matcher(). --- LVM2/daemons/dmeventd/dmeventd.c 2010/12/13 10:43:57 1.72 +++ LVM2/daemons/dmeventd/dmeventd.c 2010/12/20 14:08:46 1.73 @@ -1642,7 +1642,8 @@ static void remove_lockfile(void) { - unlink(DMEVENTD_PIDFILE); + if (unlink(DMEVENTD_PIDFILE)) + perror(DMEVENTD_PIDFILE ": unlink failed"); } static void _daemonize(void)