From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-3769-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 29613 invoked by alias); 20 Dec 2010 14:20:54 -0000
Received: (qmail 29595 invoked by uid 9737); 20 Dec 2010 14:20:53 -0000
Date: Mon, 20 Dec 2010 14:20:00 -0000
Message-ID: <20101220142053.29593.qmail@sourceware.org>
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/lib/format_pool disk_rep.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2010-12/txt/msg00058.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2010-12-20 14:20:52

Modified files:
	lib/format_pool: disk_rep.c 

Log message:
	Add internal error if pointer is uninitialized
	
	Add simple check for existance of 'pl' and printer internal error message
	if device is missing instead of plain crash.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_pool/disk_rep.c.diff?cvsroot=lvm2&r1=1.17&r2=1.18

--- LVM2/lib/format_pool/disk_rep.c	2010/07/09 15:34:44	1.17
+++ LVM2/lib/format_pool/disk_rep.c	2010/12/20 14:20:52	1.18
@@ -263,6 +263,11 @@
 		 */
 		if (!sp_count) {
 			/* FIXME pl left uninitialised if !info->dev */
+			if (!pl) {
+				log_error(INTERNAL_ERROR "device is missing");
+				dm_pool_destroy(tmpmem);
+				return 0;
+			}
 			sp_count = pl->pd.pl_subpools;
 			if (!(sp_devs =
 			      dm_pool_zalloc(tmpmem,