From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-3783-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 20411 invoked by alias); 22 Dec 2010 15:36:43 -0000
Received: (qmail 20348 invoked by uid 9737); 22 Dec 2010 15:36:43 -0000
Date: Wed, 22 Dec 2010 15:36:00 -0000
Message-ID: <20101222153643.20331.qmail@sourceware.org>
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW lib/metadata/metadata.c tools ...
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2010-12/txt/msg00072.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2010-12-22 15:36:42

Modified files:
	.              : WHATS_NEW 
	lib/metadata   : metadata.c 
	tools          : vgrename.c 

Log message:
	Add backtraces for backup and backup_remove fail paths

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1854&r2=1.1855
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.418&r2=1.419
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgrename.c.diff?cvsroot=lvm2&r1=1.73&r2=1.74

--- LVM2/WHATS_NEW	2010/12/22 15:28:44	1.1854
+++ LVM2/WHATS_NEW	2010/12/22 15:36:41	1.1855
@@ -1,5 +1,6 @@
 Version 2.02.80 - 
 ====================================
+  Add backtraces for backup and backup_remove fail paths.
   Detect errors from dm_task_set calls in _get_device_info (dmeventd).
   Add backtraces for archive and backup_locally in check_current_backup().
   Fix memory leak in debug mode of restart_clvmd() error path.
--- LVM2/lib/metadata/metadata.c	2010/12/14 17:51:09	1.418
+++ LVM2/lib/metadata/metadata.c	2010/12/22 15:36:41	1.419
@@ -611,7 +611,8 @@
 		}
 	}
 
-	backup_remove(vg->cmd, vg->name);
+	if (!backup_remove(vg->cmd, vg->name))
+		stack;
 
 	if (ret)
 		log_print("Volume group \"%s\" successfully removed", vg->name);
--- LVM2/tools/vgrename.c	2010/12/08 20:50:51	1.73
+++ LVM2/tools/vgrename.c	2010/12/22 15:36:42	1.74
@@ -164,8 +164,10 @@
 		}
 	}
 
-	backup(vg);
-	backup_remove(cmd, vg_name_old);
+	if (!backup(vg))
+		stack;
+	if (!backup_remove(cmd, vg_name_old))
+		stack;
 
 	unlock_vg(cmd, vg_name_new);
 	unlock_and_free_vg(cmd, vg, vg_name_old);