public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/format_text import_vsn1.c Date: Wed, 22 Dec 2010 15:44:00 -0000 [thread overview] Message-ID: <20101222154410.26105.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2010-12-22 15:44:09 Modified files: lib/format_text: import_vsn1.c Log message: Remove check for existance of vg pointer Checking for vg being != NULL in this place is not needed. Pointer vg is already dereferced in this function above this code line. Also this internal function _read_pv is always called with valid 'vg' pointer. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/import_vsn1.c.diff?cvsroot=lvm2&r1=1.79&r2=1.80 --- LVM2/lib/format_text/import_vsn1.c 2010/12/20 13:12:56 1.79 +++ LVM2/lib/format_text/import_vsn1.c 2010/12/22 15:44:09 1.80 @@ -257,14 +257,10 @@ log_verbose("Fixing up missing size (%s) " "for PV %s", display_size(fid->fmt->cmd, pv->size), pv_dev_name(pv)); - if (vg) { - size = pv->pe_count * (uint64_t) vg->extent_size + - pv->pe_start; - if (size > pv->size) - log_warn("WARNING: Physical Volume %s is too " - "large for underlying device", - pv_dev_name(pv)); - } + size = pv->pe_count * (uint64_t) vg->extent_size + pv->pe_start; + if (size > pv->size) + log_warn("WARNING: Physical Volume %s is too large " + "for underlying device", pv_dev_name(pv)); } if (!alloc_pv_segment_whole_pv(mem, pv))
next reply other threads:[~2010-12-22 15:44 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-12-22 15:44 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-27 11:40 zkabelac 2012-01-19 15:17 zkabelac 2011-03-27 13:44 agk 2011-01-06 15:25 zkabelac 2010-04-06 14:04 wysochanski 2008-07-11 9:19 mornfall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101222154410.26105.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).