public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/report/properties.c Date: Wed, 05 Jan 2011 12:33:00 -0000 [thread overview] Message-ID: <20110105123356.3167.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-01-05 12:33:53 Modified files: . : WHATS_NEW lib/report : properties.c Log message: Return PERCENT_INVALID for error case If the percent value could not be determined return PERCENT_INVALID. Indent function with tabs. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1857&r2=1.1858 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/report/properties.c.diff?cvsroot=lvm2&r1=1.27&r2=1.28 --- LVM2/WHATS_NEW 2011/01/04 21:33:06 1.1857 +++ LVM2/WHATS_NEW 2011/01/05 12:33:51 1.1858 @@ -1,5 +1,6 @@ Version 2.02.80 - ==================================== + Return defined value for errors in _copy_percent() and _snap_percent(). Correct return code of cmirrord when issuing 'start' when already running. Fix wrongly paired unlocking of global lock in pvchange. (2.02.66) Add backtraces for backup and backup_remove fail paths. --- LVM2/lib/report/properties.c 2010/12/14 23:20:58 1.27 +++ LVM2/lib/report/properties.c 2011/01/05 12:33:52 1.28 @@ -87,15 +87,18 @@ } static percent_t _copy_percent(const struct logical_volume *lv) { - percent_t perc; - lv_mirror_percent(lv->vg->cmd, (struct logical_volume *) lv, 0, &perc, NULL); - return perc; + percent_t perc; + if (!lv_mirror_percent(lv->vg->cmd, (struct logical_volume *) lv, + 0, &perc, NULL)) + perc = PERCENT_INVALID; + return perc; } static percent_t _snap_percent(const struct logical_volume *lv) { - percent_t perc; - lv_snapshot_percent(lv, &perc); - return perc; + percent_t perc; + if (!lv_snapshot_percent(lv, &perc)) + perc = PERCENT_INVALID; + return perc; } /* PV */
reply other threads:[~2011-01-05 12:33 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110105123356.3167.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).