public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/test/lib check.sh Date: Fri, 28 Jan 2011 16:08:00 -0000 [thread overview] Message-ID: <20110128160839.30974.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-01-28 16:08:39 Modified files: test/lib : check.sh Log message: Do not break pipes As the option 'set -e -o pipefail' is very sensite on pipe breaking stop using '-q' for grep commands. Otherwise this command (with large enough table) would fail: dmsetup table | egrep -q with exit code 141 (128 + SIGPIPE) As Peter suggested, he prefers to keep '-o pipefail' - so make sure all piped commands will read the whole output and will not exit too early. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/lib/check.sh.diff?cvsroot=lvm2&r1=1.3&r2=1.4 --- LVM2/test/lib/check.sh 2011/01/07 14:42:35 1.3 +++ LVM2/test/lib/check.sh 2011/01/28 16:08:39 1.4 @@ -139,9 +139,9 @@ mirror_nonredundant() { lv="$1/$2" - lvs -oattr "$lv" | grep -q "^ *m.....$" || { - if lvs -oattr "$lv" | grep -q "^ *o.....$" && - lvs -a | fgrep -q "[${2}_mimage"; then + lvs -oattr "$lv" | grep "^ *m.....$" >/dev/null || { + if lvs -oattr "$lv" | grep "^ *o.....$" >/dev/null && + lvs -a | fgrep "[${2}_mimage" >/dev/null; then echo "TEST WARNING: $lv is a snapshot origin and looks like a mirror," echo "assuming it is actually a mirror" else @@ -174,7 +174,7 @@ linear() { lv="$1/$2" - lvl -ostripes "$lv" | grep -q "1" || { + lvl -ostripes "$lv" | grep "1" >/dev/null || { echo "$lv expected linear, but is not:" lvl "$lv" -o+devices exit 1 @@ -183,12 +183,12 @@ active() { lv="$1/$2" - lvl -oattr "$lv" 2> /dev/null | grep -q "^ *....a.$" || { + lvl -oattr "$lv" 2> /dev/null | grep "^ *....a.$" >/dev/null || { echo "$lv expected active, but lvs says it's not:" lvl "$lv" -o+devices 2>/dev/null exit 1 } - dmsetup table | egrep -q "$1-$2: *[^ ]+" || { + dmsetup table | egrep "$1-$2: *[^ ]+" >/dev/null || { echo "$lv expected active, lvs thinks it is but there are no mappings!" dmsetup table | grep $1-$2: exit 1 @@ -197,12 +197,12 @@ inactive() { lv="$1/$2" - lvl -oattr "$lv" 2> /dev/null | grep -q '^ *....[-isd].$' || { + lvl -oattr "$lv" 2> /dev/null | grep '^ *....[-isd].$' >/dev/null || { echo "$lv expected inactive, but lvs says it's not:" lvl "$lv" -o+devices 2>/dev/null exit 1 } - dmsetup table | not egrep -q "$1-$2: *[^ ]+" || { + dmsetup table | not egrep "$1-$2: *[^ ]+" >/dev/null || { echo "$lv expected inactive, lvs thinks it is but there are mappings!" dmsetup table | grep $1-$2: exit 1
next reply other threads:[~2011-01-28 16:08 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-01-28 16:08 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-09-09 13:19 zkabelac 2011-01-07 14:42 mornfall 2011-01-07 13:03 mornfall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110128160839.30974.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).