public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 daemons/clvmd/lvm-functions.c lib/locking ... Date: Fri, 04 Feb 2011 19:21:00 -0000 [thread overview] Message-ID: <20110204192148.22647.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-02-04 19:21:47 Modified files: daemons/clvmd : lvm-functions.c lib/locking : no_locking.c Log message: Remove extra sync calls. Remove temporaly added fs_unlock() calls to fix clmvd usablity. Now when the message passing is properly working - they are no longer needed. Simplify no_locking check for VG unlock - as message is always send for all targets - clustered & non-clustered. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/lvm-functions.c.diff?cvsroot=lvm2&r1=1.109&r2=1.110 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/locking/no_locking.c.diff?cvsroot=lvm2&r1=1.26&r2=1.27 --- LVM2/daemons/clvmd/lvm-functions.c 2011/02/03 16:03:13 1.109 +++ LVM2/daemons/clvmd/lvm-functions.c 2011/02/04 19:21:47 1.110 @@ -507,7 +507,6 @@ switch (command & LCK_MASK) { case LCK_LV_EXCLUSIVE: status = do_activate_lv(resource, lock_flags, LCK_EXCL); - fs_unlock(); break; case LCK_LV_SUSPEND: @@ -517,17 +516,14 @@ case LCK_UNLOCK: case LCK_LV_RESUME: /* if active */ status = do_resume_lv(resource, lock_flags); - fs_unlock(); break; case LCK_LV_ACTIVATE: status = do_activate_lv(resource, lock_flags, LCK_READ); - fs_unlock(); break; case LCK_LV_DEACTIVATE: status = do_deactivate_lv(resource, lock_flags); - fs_unlock(); break; default: --- LVM2/lib/locking/no_locking.c 2011/02/02 20:04:39 1.26 +++ LVM2/lib/locking/no_locking.c 2011/02/04 19:21:47 1.27 @@ -38,9 +38,7 @@ { switch (flags & LCK_SCOPE_MASK) { case LCK_VG: - if (!strcmp(resource, VG_SYNC_NAMES) || - (((flags & LCK_TYPE_MASK) == LCK_UNLOCK) && - is_real_vg(resource))) + if (!strcmp(resource, VG_SYNC_NAMES)) fs_unlock(); break; case LCK_LV:
next reply other threads:[~2011-02-04 19:21 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-04 19:21 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-02-02 20:04 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110204192148.22647.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).