public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: prajnoha@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools pvresize.c Date: Mon, 28 Feb 2011 17:08:00 -0000 [thread overview] Message-ID: <20110228170809.31229.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: prajnoha@sourceware.org 2011-02-28 17:08:09 Modified files: tools : pvresize.c Log message: Add a hint for manual revert if there's an error in pv_write, vg_write, vg_commit for pvresize. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvresize.c.diff?cvsroot=lvm2&r1=1.42&r2=1.43 --- LVM2/tools/pvresize.c 2011/02/28 13:19:03 1.42 +++ LVM2/tools/pvresize.c 2011/02/28 17:08:09 1.43 @@ -35,6 +35,7 @@ const char *pv_name = pv_dev_name(pv); const char *vg_name = pv_vg_name(pv); struct volume_group *old_vg = vg; + int vg_needs_pv_write = 0; if (is_orphan_vg(vg_name)) { if (!lock_vol(cmd, vg_name, LCK_VG_WRITE)) { @@ -100,7 +101,8 @@ /* Write PV label only if this an orphan PV or it has 2nd mda. */ if ((is_orphan_vg(vg_name) || - fid_get_mda_indexed(vg->fid, (const char *) &pv->id, ID_LEN, 1)) && + (vg_needs_pv_write = (fid_get_mda_indexed(vg->fid, + (const char *) &pv->id, ID_LEN, 1) != NULL))) && !pv_write(cmd, pv, 1)) { log_error("Failed to store physical volume \"%s\"", pv_name); @@ -120,6 +122,9 @@ r = 1; out: + if (!r && vg_needs_pv_write) + log_error("Use pvcreate and vgcfgrestore " + "to repair from archived metadata."); unlock_vg(cmd, vg_name); if (!old_vg) free_vg(vg);
next reply other threads:[~2011-02-28 17:08 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-28 17:08 prajnoha [this message] -- strict thread matches above, loose matches on Subject: below -- 2007-08-30 20:16 wysochanski 2007-06-13 22:16 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110228170809.31229.qmail@sourceware.org \ --to=prajnoha@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).