public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: prajnoha@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/format_text format-text.c Date: Wed, 02 Mar 2011 10:23:00 -0000 [thread overview] Message-ID: <20110302102330.15491.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: prajnoha@sourceware.org 2011-03-02 10:23:29 Modified files: lib/format_text: format-text.c Log message: Use a copy if moving an mda from pv fid to vg fid. We'll destroy the pv fid (with all mdas in it) after merging all pv mdas to a vg in _text_pv_setup fn, hence we need to use a copy here! Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/format-text.c.diff?cvsroot=lvm2&r1=1.172&r2=1.173 --- LVM2/lib/format_text/format-text.c 2011/03/02 10:19:14 1.172 +++ LVM2/lib/format_text/format-text.c 2011/03/02 10:23:29 1.173 @@ -1647,7 +1647,7 @@ const char *pvid = (const char *) (*pv->old_id.uuid ? &pv->old_id : &pv->id); struct lvmcache_info *info; unsigned mda_index; - struct metadata_area *pv_mda; + struct metadata_area *pv_mda, *pv_mda_copy; struct mda_context *pv_mdac; uint64_t pe_count; uint64_t size_reduction = 0; @@ -1659,8 +1659,10 @@ continue; /* Be sure it's not already in VG's format instance! */ - if (!fid_get_mda_indexed(vg->fid, pvid, ID_LEN, mda_index)) - fid_add_mda(vg->fid, pv_mda, pvid, ID_LEN, mda_index); + if (!fid_get_mda_indexed(vg->fid, pvid, ID_LEN, mda_index)) { + pv_mda_copy = mda_copy(vg->fid->fmt->cmd->mem, pv_mda); + fid_add_mda(vg->fid, pv_mda_copy, pvid, ID_LEN, mda_index); + } } } /*
next reply other threads:[~2011-03-02 10:23 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-03-02 10:23 prajnoha [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-27 9:54 zkabelac 2011-02-28 17:05 prajnoha 2011-02-25 13:50 prajnoha 2011-02-21 12:25 prajnoha 2010-11-29 11:16 zkabelac 2010-08-26 12:22 mbroz 2010-06-29 13:29 wysochanski 2010-06-28 20:30 wysochanski 2009-07-31 14:23 snitzer 2009-07-30 17:41 snitzer 2006-04-21 15:37 agk 2005-10-31 2:37 agk 2005-04-06 16:35 agk 2004-05-05 18:17 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110302102330.15491.qmail@sourceware.org \ --to=prajnoha@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).