public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW_DM libdm/ioctl/libdm-iface.c Date: Tue, 08 Mar 2011 22:43:00 -0000 [thread overview] Message-ID: <20110308224322.21943.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-03-08 22:43:20 Modified files: . : WHATS_NEW_DM libdm/ioctl : libdm-iface.c Log message: Fix reading byte from char params[-1] position When the ->params string is empty - memory access is made on the byte before allocated buffer (catched by valgrind) - in the case it would constain 0x20 - it would even overwrite this buffer. So fix by checking len > 0 before doing such access. Also slightly optimise this loop from repeated strlen call. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.453&r2=1.454 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/ioctl/libdm-iface.c.diff?cvsroot=lvm2&r1=1.98&r2=1.99 --- LVM2/WHATS_NEW_DM 2011/03/03 13:05:40 1.453 +++ LVM2/WHATS_NEW_DM 2011/03/08 22:43:19 1.454 @@ -1,5 +1,6 @@ Version 1.02.64 - =================================== + Fix memory access of empty params string in _reload_with_suppression_v4(). Lower severity of selabel_lookup and matchpathcon failure to log_debug. Accept multiple mapped device names on many dmsetup command lines. Fix dm_udev_wait calls in dmsetup to occur before readahead display not after. --- LVM2/libdm/ioctl/libdm-iface.c 2011/03/05 21:17:19 1.98 +++ LVM2/libdm/ioctl/libdm-iface.c 2011/03/08 22:43:20 1.99 @@ -1836,6 +1836,7 @@ { struct dm_task *task; struct target *t1, *t2; + size_t len; int r; /* New task to get existing table information */ @@ -1878,8 +1879,9 @@ t2 = task->head; while (t1 && t2) { - while (t2->params[strlen(t2->params) - 1] == ' ') - t2->params[strlen(t2->params) - 1] = '\0'; + len = strlen(t2->params); + while (len-- > 0 && t2->params[len] == ' ') + t2->params[len] = '\0'; if ((t1->start != t2->start) || (t1->length != t2->length) || (strcmp(t1->type, t2->type)) ||
next reply other threads:[~2011-03-08 22:43 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-03-08 22:43 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-01 10:07 zkabelac 2012-02-15 12:17 prajnoha 2012-02-08 12:59 zkabelac 2012-02-08 11:25 zkabelac 2011-11-08 17:32 snitzer 2011-10-20 10:38 zkabelac 2011-09-13 15:13 prajnoha 2011-08-11 20:49 zkabelac 2011-07-24 23:59 agk 2011-07-02 1:17 agk 2011-06-09 15:07 mbroz 2011-03-25 23:50 agk 2011-03-01 23:27 agk 2011-02-21 16:26 snitzer 2010-08-18 13:11 prajnoha 2010-05-13 13:31 mbroz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110308224322.21943.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).