public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/lib/cache lvmcache.c
Date: Sun, 13 Mar 2011 23:01:00 -0000	[thread overview]
Message-ID: <20110313230108.13989.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-03-13 23:01:08

Modified files:
	lib/cache      : lvmcache.c 

Log message:
	Use proper size of strncpy
	
	Avoid reading extra character if we expect to have there '\0'.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/cache/lvmcache.c.diff?cvsroot=lvm2&r1=1.106&r2=1.107

--- LVM2/lib/cache/lvmcache.c	2011/03/11 15:08:31	1.106
+++ LVM2/lib/cache/lvmcache.c	2011/03/13 23:01:08	1.107
@@ -1287,7 +1287,7 @@
 		return NULL;
 	}
 
-	strncpy(pvid_s, pvid, sizeof(pvid_s));
+	strncpy(pvid_s, pvid, sizeof(pvid_s) - 1);
 	pvid_s[sizeof(pvid_s) - 1] = '\0';
 
 	if (!(existing = info_from_pvid(pvid_s, 0)) &&


             reply	other threads:[~2011-03-13 23:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-13 23:01 zkabelac [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-03-01 21:58 zkabelac
2012-03-01 21:57 zkabelac
2012-02-28 18:20 agk
2012-02-28 11:08 zkabelac
2012-02-28 10:10 zkabelac
2012-02-13 14:26 zkabelac
2011-12-08 23:18 agk
2011-04-21 13:15 zkabelac
2010-10-25 13:33 zkabelac
2010-04-30 12:54 zkabelac
2010-03-16 19:06 agk
2010-01-11 19:12 snitzer
2010-01-11 19:08 snitzer
2009-04-24 12:03 mbroz
2008-11-28 15:51 agk
2008-06-06 12:43 agk
2008-04-15 14:54 agk
2008-01-30 16:18 agk
2007-11-05 17:12 agk
2006-04-21 14:44 agk
2005-09-16 18:45 agk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110313230108.13989.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).