public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 lib/metadata/metadata.c ./WHATS_NEW
Date: Mon, 14 Mar 2011 17:01:00 -0000	[thread overview]
Message-ID: <20110314170058.28997.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-03-14 17:00:58

Modified files:
	lib/metadata   : metadata.c 
	.              : WHATS_NEW 

Log message:
	Add missing \0 for grown debug object
	
	Attach \0 for proper char* display - otherwise somewhat random message could
	be displayed in debug more and read of unpredictable read of uninitilized
	memory values could happen.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.449&r2=1.450
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1955&r2=1.1956

--- LVM2/lib/metadata/metadata.c	2011/03/13 23:05:49	1.449
+++ LVM2/lib/metadata/metadata.c	2011/03/14 17:00:57	1.450
@@ -1066,6 +1066,12 @@
 		}
 	}
 
+	if (!dm_pool_grow_object(mem, "\0", 1)) {
+		log_error("Failed to finish list of random bits.");
+		dm_pool_free(mem, bs);
+		return NULL;
+	}
+
 	log_debug("Selected %" PRIu32 " random bits from %" PRIu32 ": %s", num_set_bits, num_bits, (char *) dm_pool_end_object(mem));
 
 	return bs;
--- LVM2/WHATS_NEW	2011/03/13 23:18:30	1.1955
+++ LVM2/WHATS_NEW	2011/03/14 17:00:58	1.1956
@@ -1,5 +1,6 @@
 Version 2.02.85 - 
 ===================================
+  Add missing \0 for grown debug object in _bitset_with_random_bits().
   Fix allocation of system_id buffer in volume_group structure.
   Fix readlink usage inside get_primary_dev().
   Use format instance mempool where possible and adequate.


             reply	other threads:[~2011-03-14 17:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-14 17:01 zkabelac [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-03-10 14:40 zkabelac
2009-05-30  1:54 agk
2008-06-08 14:18 agk
2008-06-06  9:48 agk
2007-06-11 18:29 wysochanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110314170058.28997.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).