public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 libdm/libdm-common.c libdm/ioctl/libdm-if ...
Date: Fri, 18 Mar 2011 13:21:00 -0000	[thread overview]
Message-ID: <20110318132105.18078.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-03-18 13:21:03

Modified files:
	libdm          : libdm-common.c 
	libdm/ioctl    : libdm-iface.c 
	.              : WHATS_NEW_DM 

Log message:
	Improve debug stack trace
	
	dm_check_version reports log_error() - so use return_NULL.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-common.c.diff?cvsroot=lvm2&r1=1.113&r2=1.114
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/ioctl/libdm-iface.c.diff?cvsroot=lvm2&r1=1.100&r2=1.101
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW_DM.diff?cvsroot=lvm2&r1=1.456&r2=1.457

--- LVM2/libdm/libdm-common.c	2011/03/03 13:05:41	1.113
+++ LVM2/libdm/libdm-common.c	2011/03/18 13:21:02	1.114
@@ -183,7 +183,7 @@
 
 	if (!dm_check_version()) {
 		dm_free(dmt);
-		return NULL;
+		return_NULL;
 	}
 
 	dmt->type = type;
--- LVM2/libdm/ioctl/libdm-iface.c	2011/03/18 12:17:58	1.100
+++ LVM2/libdm/ioctl/libdm-iface.c	2011/03/18 13:21:02	1.101
@@ -965,8 +965,10 @@
 	if (_check_version(dmversion, sizeof(dmversion), _dm_compat))
 		return 1;
 
-	if (!_dm_compat)
+	if (!_dm_compat) {
+		log_error("Support for older device-mapped version is disabled.");
 		goto bad;
+	}
 
 	log_verbose("device-mapper ioctl protocol version %u failed. "
 		    "Trying protocol version 1.", _dm_version);
--- LVM2/WHATS_NEW_DM	2011/03/18 12:17:57	1.456
+++ LVM2/WHATS_NEW_DM	2011/03/18 13:21:03	1.457
@@ -1,5 +1,6 @@
 Version 1.02.64 - 
 ===================================
+  Improve stack debug reporting in dm_task_create().
   Fallback to control node creation only if node doesn't exist yet.
   Change dm_hash API for binary data to accept const void *key.
   Fix memory access of empty params string in _reload_with_suppression_v4().


                 reply	other threads:[~2011-03-18 13:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110318132105.18078.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    --cc=lvm2-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).