public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/daemons/clvmd clvmd-singlenode.c
Date: Thu, 24 Mar 2011 10:45:00 -0000 [thread overview]
Message-ID: <20110324104502.9024.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2011-03-24 10:45:01
Modified files:
daemons/clvmd : clvmd-singlenode.c
Log message:
Release allocated memory on closedown
Release allocated buffers before exit() in debug singlenode - so it's not
poping out in valgrind as memory leak.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd-singlenode.c.diff?cvsroot=lvm2&r1=1.9&r2=1.10
--- LVM2/daemons/clvmd/clvmd-singlenode.c 2010/12/13 10:43:56 1.9
+++ LVM2/daemons/clvmd/clvmd-singlenode.c 2011/03/24 10:45:00 1.10
@@ -28,6 +28,8 @@
static const char SINGLENODE_CLVMD_SOCKNAME[] = DEFAULT_RUN_DIR "/clvmd_singlenode.sock";
static int listen_fd = -1;
+static int *_locks = NULL;
+static char **_resources = NULL;
static void close_comms(void)
{
@@ -97,6 +99,10 @@
DEBUGLOG("cluster_closedown\n");
destroy_lvhash();
+ dm_free(_locks);
+ dm_free(_resources);
+ _locks = NULL;
+ _resources = NULL;
}
static void _get_our_csid(char *csid)
@@ -136,8 +142,6 @@
int _lock_file(const char *file, uint32_t flags);
-static int *_locks = NULL;
-static char **_resources = NULL;
static int _lock_max = 1;
static pthread_mutex_t _lock_mutex = PTHREAD_MUTEX_INITIALIZER;
next reply other threads:[~2011-03-24 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 10:45 zkabelac [this message]
2011-09-29 8:57 zkabelac
2011-11-07 17:11 mornfall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324104502.9024.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).