From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9477 invoked by alias); 25 Mar 2011 21:56:29 -0000 Received: (qmail 9453 invoked by uid 9478); 25 Mar 2011 21:56:28 -0000 Date: Fri, 25 Mar 2011 21:56:00 -0000 Message-ID: <20110325215628.9451.qmail@sourceware.org> From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools lvcreate.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00073.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2011-03-25 21:56:28 Modified files: tools : lvcreate.c Log message: cosmetic change - swapping one macro for another When I see 'seg_is_mirrored', I expect the argument to be an lv_segment. In this case, it is lvcreate_params. Both structures, have a 'segtype' entry which the macro dereferences. However, it just seems easier to understand if we do 'segtype_is_mirrored' instead. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.229&r2=1.230 --- LVM2/tools/lvcreate.c 2011/02/18 14:47:31 1.229 +++ LVM2/tools/lvcreate.c 2011/03/25 21:56:28 1.230 @@ -346,7 +346,7 @@ lp->mirrors = 1; /* Default to 2 mirrored areas if --type mirror */ - if (seg_is_mirrored(lp)) + if (segtype_is_mirrored(lp->segtype)) lp->mirrors = 2; if (arg_count(cmd, mirrors_ARG)) {