public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/lv_manip.c Date: Thu, 07 Apr 2011 21:49:00 -0000 [thread overview] Message-ID: <20110407214931.10279.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2011-04-07 21:49:30 Modified files: . : WHATS_NEW lib/metadata : lv_manip.c Log message: Thanks to Zdenek Kabelac (kabi) for pointing out that I was using dm_pool_free incorrectly. This check-in fixes that incorrect usage. I've also added a WHATS_NEW line to reflect the changes I made to allow lv_extend to operate on 0 length intrinsically layered LVs (i.e mirrors and RAID). I forgot that in the last commit. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1967&r2=1.1968 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/lv_manip.c.diff?cvsroot=lvm2&r1=1.255&r2=1.256 --- LVM2/WHATS_NEW 2011/03/30 13:14:34 1.1967 +++ LVM2/WHATS_NEW 2011/04/07 21:49:29 1.1968 @@ -1,5 +1,6 @@ Version 2.02.85 - =================================== + Allow lv_extend() to work on zero length intrinsically layered LVs. Keep the cache content when the exported vg buffer is matching. Extend the set of memory regions, that are not locked to memory. Enhance usability with the valgrind memcheck tool. --- LVM2/lib/metadata/lv_manip.c 2011/04/06 21:32:20 1.255 +++ LVM2/lib/metadata/lv_manip.c 2011/04/07 21:49:29 1.256 @@ -2114,8 +2114,8 @@ struct logical_volume *sub_lv; uint32_t i; uint64_t status = 0; - char *img_name; - size_t len; + size_t len = strlen(lv->name) + 32; + char img_name[len]; struct lv_segment *mapseg; if (lv->le_count || first_seg(lv)) { @@ -2141,9 +2141,6 @@ /* * Next, create all of our sub_lv's and link them in. */ - len = strlen(lv->name) + 32; - if (!(img_name = dm_pool_alloc(lv->vg->cmd->mem, len))) - return_0; if (dm_snprintf(img_name, len, "%s%s", lv->name, "_mimage_%d") < 0) return_0; @@ -2157,7 +2154,6 @@ } dm_list_add(&lv->segments, &mapseg->list); - dm_pool_free(lv->vg->cmd->mem, img_name); return 1; }
next reply other threads:[~2011-04-07 21:49 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-04-07 21:49 jbrassow [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-05-11 22:19 agk 2012-05-11 18:59 agk 2012-05-09 12:12 zkabelac 2012-03-05 14:13 zkabelac 2012-02-29 22:09 zkabelac 2012-02-22 17:14 jbrassow 2012-02-09 15:13 prajnoha 2012-02-08 13:02 zkabelac 2012-01-20 22:04 snitzer 2011-11-15 17:32 zkabelac 2011-11-15 17:28 zkabelac 2011-10-28 20:23 zkabelac 2011-10-28 20:17 zkabelac 2011-09-14 14:20 mbroz 2011-09-13 18:43 jbrassow 2011-06-29 17:05 agk 2011-02-27 1:16 agk 2011-01-28 2:58 snitzer 2010-12-20 14:38 zkabelac 2010-12-01 12:56 zkabelac 2010-03-29 17:59 agk 2010-03-25 18:16 agk 2010-03-23 15:07 agk 2010-01-12 20:53 agk 2010-01-05 15:58 mbroz 2009-05-30 0:09 agk 2009-05-28 1:59 agk 2009-05-28 0:29 agk 2008-12-19 15:26 mbroz 2008-10-23 11:21 agk 2008-10-17 10:57 agk 2008-09-29 9:59 mbroz 2008-02-22 13:22 agk 2007-01-05 15:53 mbroz 2006-12-12 19:30 agk 2006-10-30 16:10 agk 2006-10-07 23:40 agk 2006-10-07 12:41 agk 2006-10-07 11:00 agk 2006-10-05 21:24 agk 2005-11-28 20:01 agk 2005-11-24 18:46 agk 2005-07-12 14:50 agk 2005-06-03 18:07 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110407214931.10279.qmail@sourceware.org \ --to=jbrassow@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).