From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-4191-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 4716 invoked by alias); 17 Jun 2011 14:24:19 -0000
Received: (qmail 4688 invoked by uid 9737); 17 Jun 2011 14:24:18 -0000
Date: Fri, 17 Jun 2011 14:24:00 -0000
Message-ID: <20110617142418.4686.qmail@sourceware.org>
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/lib activate/activate.c metadata/mirror.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2011-06/txt/msg00038.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-06-17 14:24:18

Modified files:
	lib/activate   : activate.c 
	lib/metadata   : mirror.c 

Log message:
	Add couple FIXMEs around suspicious code

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/activate.c.diff?cvsroot=lvm2&r1=1.200&r2=1.201
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.152&r2=1.153

--- LVM2/lib/activate/activate.c	2011/06/17 14:22:48	1.200
+++ LVM2/lib/activate/activate.c	2011/06/17 14:24:18	1.201
@@ -795,12 +795,14 @@
 		goto out;
 	}
 
+	/* FIXME: Is this fallback alright? */
 	if (activate_lv_excl(lv->vg->cmd, lv)) {
 		if (!deactivate_lv(lv->vg->cmd, lv))
 			stack;
+		/* FIXME: locally & exclusive are undefined. */
 		return 0;
 	}
-
+	/* FIXME: Check exclusive value here. */
 out:
 	if (locally)
 		*locally = l;
--- LVM2/lib/metadata/mirror.c	2011/06/11 00:03:07	1.152
+++ LVM2/lib/metadata/mirror.c	2011/06/17 14:24:18	1.153
@@ -2020,6 +2020,7 @@
 	}
 
 	if (vg_is_clustered(lv->vg)) {
+		/* FIXME: review check of lv_is_active_remotely */
 		if (!(lv->status & ACTIVATE_EXCL) &&
 		    !cluster_mirror_is_available(lv)) {
 			log_error("Shared cluster mirrors are not available.");