From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6329 invoked by alias); 29 Jun 2011 08:54:15 -0000 Received: (qmail 6311 invoked by uid 9447); 29 Jun 2011 08:54:14 -0000 Date: Wed, 29 Jun 2011 08:54:00 -0000 Message-ID: <20110629085414.6309.qmail@sourceware.org> From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/libdm/ioctl libdm-iface.c Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: lvm2-cvs-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00069.txt.bz2 CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2011-06-29 08:54:14 Modified files: libdm/ioctl : libdm-iface.c Log message: Temporary conversion to internal error and failure, to see how many instances of this problem this flushes out. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/ioctl/libdm-iface.c.diff?cvsroot=lvm2&r1=1.108&r2=1.109 --- LVM2/libdm/ioctl/libdm-iface.c 2011/06/27 21:43:59 1.108 +++ LVM2/libdm/ioctl/libdm-iface.c 2011/06/29 08:54:13 1.109 @@ -2059,8 +2059,8 @@ } if ((suspended_counter = dm_get_suspended_counter()) && - dmt->type == DM_DEVICE_RELOAD) - log_error("Performing unsafe table load while %d device(s) " + dmt->type == DM_DEVICE_RELOAD) { + log_error(INTERNAL_ERROR "Performing unsafe table load while %d device(s) " "are known to be suspended: " "%s%s%s %s%.0d%s%.0d%s%s", suspended_counter, @@ -2073,6 +2073,8 @@ dmt->minor > 0 ? dmt->minor : 0, dmt->major > 0 && dmt->minor == 0 ? "0" : "", dmt->major > 0 ? ") " : ""); + return 0; + } /* FIXME Detect and warn if cookie set but should not be. */ repeat_ioctl: