public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW libdm/libdm-deptree.c
Date: Thu, 30 Jun 2011 09:24:00 -0000 [thread overview]
Message-ID: <20110630092459.21613.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2011-06-30 09:24:59
Modified files:
. : WHATS_NEW
libdm : libdm-deptree.c
Log message:
Report internal error when parameters are missing on table load
When some target is passing empty parameters to some dm target,
report this as an internal error to better catch some broken
table construction (some mirror conversions seem to be doing
this for now).
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2032&r2=1.2033
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-deptree.c.diff?cvsroot=lvm2&r1=1.100&r2=1.101
--- LVM2/WHATS_NEW 2011/06/30 09:15:53 1.2032
+++ LVM2/WHATS_NEW 2011/06/30 09:24:58 1.2033
@@ -1,5 +1,6 @@
Version 2.02.86 -
=================================
+ Report internal error when parameters are missing on table load.
Teardown any stray devices with $COMMON_PREFIX during test runs.
Reinstate correct permissions when creating mirrors. [2.02.85]
Append 'm' attribute to pv_attr for missing PVs.
--- LVM2/libdm/libdm-deptree.c 2011/06/27 22:38:53 1.100
+++ LVM2/libdm/libdm-deptree.c 2011/06/30 09:24:58 1.101
@@ -1754,6 +1754,10 @@
stack;
return r;
}
+ if (!params[0])
+ log_error(INTERNAL_ERROR "Empty parameters for "
+ "%s %u:%u.", dm_segtypes[seg->type].target,
+ major, minor);
break;
}
next reply other threads:[~2011-06-30 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 9:24 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-04 17:36 zkabelac
2010-11-23 18:29 zkabelac
2010-06-21 8:54 prajnoha
2010-05-21 12:30 zkabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630092459.21613.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).