public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/lib/metadata snapshot_manip.c Date: Tue, 19 Jul 2011 16:23:00 -0000 [thread overview] Message-ID: <20110719162353.18391.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2011-07-19 16:23:52 Modified files: lib/metadata : snapshot_manip.c Log message: Fix potential null ptr deref in 'origin_from_cow' return NULL rather than segfaulting if lv->snapshot is not set Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/snapshot_manip.c.diff?cvsroot=lvm2&r1=1.50&r2=1.51 --- LVM2/lib/metadata/snapshot_manip.c 2011/07/08 12:48:41 1.50 +++ LVM2/lib/metadata/snapshot_manip.c 2011/07/19 16:23:52 1.51 @@ -81,7 +81,9 @@ /* Given a cow LV, return its origin */ struct logical_volume *origin_from_cow(const struct logical_volume *lv) { - return lv->snapshot->origin; + if (lv->snapshot) + return lv->snapshot->origin; + return NULL; } void init_snapshot_seg(struct lv_segment *seg, struct logical_volume *origin,
reply other threads:[~2011-07-19 16:23 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110719162353.18391.qmail@sourceware.org \ --to=jbrassow@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).