public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mornfall@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/daemons/lvmetad lvmetad-core.c Date: Mon, 25 Jul 2011 15:33:00 -0000 [thread overview] Message-ID: <20110725153305.27045.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mornfall@sourceware.org 2011-07-25 15:33:04 Modified files: daemons/lvmetad: lvmetad-core.c Log message: lvmetad: A couple of TODOs, and fix a few trivial memory leaks. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/lvmetad/lvmetad-core.c.diff?cvsroot=lvm2&r1=1.19&r2=1.20 --- LVM2/daemons/lvmetad/lvmetad-core.c 2011/07/20 21:33:41 1.19 +++ LVM2/daemons/lvmetad/lvmetad-core.c 2011/07/25 15:33:04 1.20 @@ -36,6 +36,11 @@ void lock_pvid_map(lvmetad_state *s) { pthread_mutex_lock(&s->lock.pvid_map); } void unlock_pvid_map(lvmetad_state *s) { pthread_mutex_unlock(&s->lock.pvid_map); } +/* + * TODO: It may be beneficial to clean up the vg lock hash from time to time, + * since if we have many "rogue" requests for nonexistent things, we will keep + * allocating memory that we never release. Not good. + */ struct config_tree *lock_vg(lvmetad_state *s, const char *id) { lock_vgs(s); pthread_mutex_t *vg = dm_hash_lookup(s->lock.vg, id); @@ -90,6 +95,10 @@ return res; } +/* + * TODO: This set_flag function is pretty generic and might make sense in a + * library here or there. + */ static void set_flag(struct config_tree *cft, struct config_node *parent, char *field, const char *flag, int want) { struct config_value *value = NULL, *pred = NULL; @@ -337,14 +346,25 @@ static int fini(daemon_state *s) { + debug("fini\n"); lvmetad_state *ls = s->private; struct dm_hash_node *n = dm_hash_get_first(ls->vgs); while (n) { destroy_config_tree(dm_hash_get_data(ls->vgs, n)); n = dm_hash_get_next(ls->vgs, n); } + + n = dm_hash_get_first(ls->lock.vg); + while (n) { + pthread_mutex_destroy(dm_hash_get_data(ls->lock.vg, n)); + free(dm_hash_get_data(ls->lock.vg, n)); + n = dm_hash_get_next(ls->lock.vg, n); + } + + dm_hash_destroy(ls->lock.vg); dm_hash_destroy(ls->pvs); dm_hash_destroy(ls->vgs); + dm_hash_destroy(ls->pvid_map); return 1; }
next reply other threads:[~2011-07-25 15:33 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-07-25 15:33 mornfall [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-23 10:34 zkabelac 2012-02-27 10:19 zkabelac 2012-02-27 10:10 zkabelac 2012-02-24 0:24 mornfall 2012-02-24 0:12 mornfall 2012-02-21 9:19 mornfall 2012-02-15 17:37 mornfall 2012-02-15 17:30 mornfall 2012-02-15 14:15 mornfall 2012-02-15 14:06 mornfall 2012-02-15 11:43 mornfall 2012-02-13 14:25 zkabelac 2012-01-25 21:42 zkabelac 2011-12-18 22:31 mornfall 2011-09-17 13:33 zkabelac 2011-09-02 11:04 zkabelac 2011-07-25 17:59 mornfall 2011-07-25 15:51 mornfall 2011-07-20 21:33 mornfall 2011-07-20 21:27 mornfall 2011-07-20 21:26 mornfall 2011-07-20 21:23 mornfall 2011-07-20 18:45 mornfall 2011-07-20 18:34 mornfall 2011-07-20 18:24 mornfall 2011-07-20 16:49 mornfall 2011-07-20 16:46 mornfall 2011-07-20 15:14 mornfall 2011-07-19 19:15 mornfall 2011-07-19 14:14 mornfall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110725153305.27045.qmail@sourceware.org \ --to=mornfall@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).