From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvm2-cvs-return-4461-listarch-lvm2-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 3983 invoked by alias); 14 Sep 2011 16:07:14 -0000
Received: (qmail 3959 invoked by uid 9737); 14 Sep 2011 16:07:08 -0000
Date: Wed, 14 Sep 2011 16:07:00 -0000
Message-ID: <20110914160708.3957.qmail@sourceware.org>
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/libdm libdm-string.c
Mailing-List: contact lvm2-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <lvm2-cvs.sourceware.org>
List-Subscribe: <mailto:lvm2-cvs-subscribe@sourceware.org>
List-Post: <mailto:lvm2-cvs@sourceware.org>
List-Help: <mailto:lvm2-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: lvm2-cvs-owner@sourceware.org
X-SW-Source: 2011-09/txt/msg00057.txt.bz2

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac@sourceware.org	2011-09-14 16:07:08

Modified files:
	libdm          : libdm-string.c 

Log message:
	Fix memory overwrite
	
	Transfer of build_dm_uuid() function into libdm made uuid_prefix as parameter,
	thus sizeof() was replaced with strlen() and room for '\0' missed.
	
	As it's only fix in current version - no whatsnew.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-string.c.diff?cvsroot=lvm2&r1=1.16&r2=1.17

--- LVM2/libdm/libdm-string.c	2011/09/01 17:58:27	1.16
+++ LVM2/libdm/libdm-string.c	2011/09/14 16:07:07	1.17
@@ -347,7 +347,7 @@
 	if (!layer)
 		layer = "";
 
-	len = strlen(uuid_prefix) + strlen(lvid) + strlen(layer) + 1;
+	len = strlen(uuid_prefix) + strlen(lvid) + strlen(layer) + 2;
 
 	if (!(dmuuid = dm_pool_alloc(mem, len))) {
 		log_error("build_dm_name: Allocation failed for %" PRIsize_t