public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/tools pvmove.c Date: Wed, 21 Sep 2011 16:36:00 -0000 [thread overview] Message-ID: <20110921163640.16609.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2011-09-21 16:36:39 Modified files: tools : pvmove.c Log message: FIXMEs to note problems with some error paths. (Perhaps safer to disable them until they can be fixed completely?) Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvmove.c.diff?cvsroot=lvm2&r1=1.86&r2=1.87 --- LVM2/tools/pvmove.c 2011/08/30 14:55:19 1.86 +++ LVM2/tools/pvmove.c 2011/09/21 16:36:39 1.87 @@ -365,6 +365,7 @@ } if (!_suspend_lvs(cmd, first_time, lv_mirr, lvs_changed)) { + /* FIXME vg_revert must be moved *before* any LV resumes */ vg_revert(vg); goto_out; } @@ -388,13 +389,16 @@ /* * Nothing changed yet, try to revert pvmove. + * FIXME This error path is incomplete and unsafe. */ log_error("Temporary pvmove mirror activation failed."); /* Ensure that temporary mrror is deactivate even on other nodes. */ + /* FIXME Unsafe to proceed if this fails without checking explicitly that no pvmove LVs are still active */ (void)deactivate_lv(cmd, lv_mirr); /* Revert metadata */ + /* FIXME Use --abort code instead? */ if (!_detach_pvmove_mirror(cmd, lv_mirr) || !lv_remove(lv_mirr) || !vg_write(vg) || !vg_commit(vg))
next reply other threads:[~2011-09-21 16:36 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-09-21 16:36 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-27 12:01 mbroz 2012-03-27 11:43 mbroz 2012-03-26 20:31 mbroz 2011-12-08 18:06 agk 2011-10-11 8:51 zkabelac 2009-12-04 14:03 prajnoha 2004-05-05 18:33 agk 2004-03-31 18:41 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110921163640.16609.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).