public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvcreate.c Date: Thu, 22 Sep 2011 15:36:00 -0000 [thread overview] Message-ID: <20110922153622.13112.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2011-09-22 15:36:21 Modified files: . : WHATS_NEW tools : lvcreate.c Log message: Disallow the creation of mirrors (mirror or raid1 segtype) with only one leg. If you specify the segment type (e.g. --type mirror) and the mirrors argument as zero, it would result in a mirrored LV with only one image. While the device may be valid in theory, it should not be allowed in practice. It also makes it difficult on the conversion tools, since they react badly to single-image mirrors. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2129&r2=1.2130 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.241&r2=1.242 --- LVM2/WHATS_NEW 2011/09/22 09:47:34 1.2129 +++ LVM2/WHATS_NEW 2011/09/22 15:36:21 1.2130 @@ -1,5 +1,6 @@ Version 2.02.89 - ================================== + Disallow the creation of mirrors (mirror or raid1 segtype) with only one leg. Cleanup restart clvmd code (no memory allocation, debug print passed args). Add all exclusive locks to clvmd restart option args. Always send the whole clvmd packet header in refresh commands. --- LVM2/tools/lvcreate.c 2011/09/15 15:26:40 1.241 +++ LVM2/tools/lvcreate.c 2011/09/22 15:36:21 1.242 @@ -618,8 +618,13 @@ if (arg_count(cmd, mirrors_ARG)) { lp->mirrors = arg_uint_value(cmd, mirrors_ARG, 0) + 1; - if (lp->mirrors == 1) + if (lp->mirrors == 1) { + if (segtype_is_mirrored(lp->segtype)) { + log_error("Image count for segtype \"%s\" cannot be 0.", lp->segtype->name); + return 0; + } log_print("Redundant mirrors argument: default is 0"); + } if (arg_sign_value(cmd, mirrors_ARG, 0) == SIGN_MINUS) { log_error("Mirrors argument may not be negative"); return 0;
next reply other threads:[~2011-09-22 15:36 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-09-22 15:36 jbrassow [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-04-11 12:33 zkabelac 2012-03-02 17:25 zkabelac 2012-03-01 21:21 zkabelac 2012-02-27 10:00 zkabelac 2011-11-07 11:01 zkabelac 2008-09-24 16:32 mbroz 2008-06-05 13:38 agk 2008-01-17 15:53 agk 2008-01-16 15:25 agk 2007-11-12 13:34 agk 2007-09-24 13:25 wysochanski 2007-09-17 17:18 agk 2007-07-17 16:13 mbroz 2006-10-26 18:22 agk 2006-05-24 13:58 agk 2005-06-22 14:56 agk 2004-10-15 15:53 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110922153622.13112.qmail@sourceware.org \ --to=jbrassow@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).