public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/libdm libdm-config.c Date: Sun, 25 Sep 2011 19:43:00 -0000 [thread overview] Message-ID: <20110925194344.18116.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-09-25 19:43:43 Modified files: libdm : libdm-config.c Log message: Add missing log_error messages Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-config.c.diff?cvsroot=lvm2&r1=1.11&r2=1.12 --- LVM2/libdm/libdm-config.c 2011/09/25 19:42:45 1.11 +++ LVM2/libdm/libdm-config.c 2011/09/25 19:43:43 1.12 @@ -543,8 +543,10 @@ { /* IDENTIFIER SECTION_B_CHAR VALUE* SECTION_E_CHAR */ struct dm_config_node *root, *n, *l = NULL; - if (!(root = _create_node(p->mem))) - return_NULL; + if (!(root = _create_node(p->mem))) { + log_error("Failed to allocate section node"); + return NULL; + } if (!(root->key = _dup_tok(p))) return_NULL; @@ -598,8 +600,10 @@ * Special case for an empty array. */ if (!h) { - if (!(h = _create_value(p->mem))) - return_NULL; + if (!(h = _create_value(p->mem))) { + log_error("Failed to allocate value"); + return NULL; + } h->type = DM_CFG_EMPTY_ARRAY; } @@ -617,8 +621,10 @@ struct dm_config_value *v = _create_value(p->mem); char *str; - if (!v) + if (!v) { + log_error("Failed to allocate type value"); return NULL; + } switch (p->t) { case TOK_INT: @@ -1251,8 +1257,10 @@ { struct dm_config_node *new_cn; - if (!cn) + if (!cn) { + log_error("Cannot clone NULL config node."); return NULL; + } if (!(new_cn = _create_node(mem))) { log_error("Failed to clone config node.");
next reply other threads:[~2011-09-25 19:43 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-09-25 19:43 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-28 17:46 agk 2012-01-23 17:47 agk 2012-01-19 15:16 zkabelac 2011-12-11 15:18 mornfall 2011-09-25 19:45 zkabelac 2011-09-25 19:42 zkabelac 2011-09-25 19:41 zkabelac 2011-09-25 19:40 zkabelac 2011-09-25 19:39 zkabelac 2011-09-01 14:02 zkabelac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110925194344.18116.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).