public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2/libdm libdm-config.c
Date: Sun, 25 Sep 2011 19:45:00 -0000 [thread overview]
Message-ID: <20110925194541.18853.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2011-09-25 19:45:40
Modified files:
libdm : libdm-config.c
Log message:
Remove test for NULL
Since it's internal function and we always check for NULL value
before call - this is safe.
Just for case add nonnull attribute so analyzer might better
catch error.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-config.c.diff?cvsroot=lvm2&r1=1.12&r2=1.13
--- LVM2/libdm/libdm-config.c 2011/09/25 19:43:43 1.12
+++ LVM2/libdm/libdm-config.c 2011/09/25 19:45:40 1.13
@@ -1225,14 +1225,12 @@
return 0;
}
+__attribute__((nonnull(1, 2)))
static struct dm_config_value *_clone_config_value(struct dm_pool *mem,
const struct dm_config_value *v)
{
struct dm_config_value *new_cv;
- if (!v)
- return NULL;
-
if (!(new_cv = _create_value(mem))) {
log_error("Failed to clone config value.");
return NULL;
next reply other threads:[~2011-09-25 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-25 19:45 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-28 17:46 agk
2012-01-23 17:47 agk
2012-01-19 15:16 zkabelac
2011-12-11 15:18 mornfall
2011-09-25 19:43 zkabelac
2011-09-25 19:42 zkabelac
2011-09-25 19:41 zkabelac
2011-09-25 19:40 zkabelac
2011-09-25 19:39 zkabelac
2011-09-01 14:02 zkabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110925194541.18853.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).