public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/daemons/clvmd clvmd.c Date: Tue, 11 Oct 2011 09:18:00 -0000 [thread overview] Message-ID: <20111011091849.6933.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-10-11 09:18:49 Modified files: daemons/clvmd : clvmd.c Log message: Limit thread stack Since default thread stack size is around 8MB and clvmd creates for now thread for message, clvmd may easily reach multi GB size of in-memory locked pages (runs with mlockall()). This patch significantly reduces memory usage to just tens of MB, and now different reasons are the cause of server overloading. Now we are running out of free file descriptors mostly. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd.c.diff?cvsroot=lvm2&r1=1.110&r2=1.111 --- LVM2/daemons/clvmd/clvmd.c 2011/09/24 20:48:34 1.110 +++ LVM2/daemons/clvmd/clvmd.c 2011/10/11 09:18:49 1.111 @@ -1,6 +1,6 @@ /* * Copyright (C) 2002-2004 Sistina Software, Inc. All rights reserved. - * Copyright (C) 2004-2009 Red Hat, Inc. All rights reserved. + * Copyright (C) 2004-2011 Red Hat, Inc. All rights reserved. * * This file is part of LVM2. * @@ -84,6 +84,9 @@ static debug_t debug = DEBUG_OFF; static int foreground_mode = 0; static pthread_t lvm_thread; +/* Stack size 128KiB for thread, must be bigger then DEFAULT_RESERVED_STACK */ +static const size_t STACK_SIZE = 128 * 1024; +static pthread_attr_t stack_attr; static pthread_mutex_t lvm_thread_mutex; static pthread_cond_t lvm_thread_cond; static pthread_mutex_t lvm_start_mutex; @@ -495,6 +498,11 @@ /* Initialise the LVM thread variables */ dm_list_init(&lvm_cmd_head); + if (pthread_attr_init(&stack_attr) || + pthread_attr_setstacksize(&stack_attr, STACK_SIZE)) { + log_sys_error("pthread_attr_init", ""); + exit(1); + } pthread_mutex_init(&lvm_thread_mutex, NULL); pthread_cond_init(&lvm_thread_cond, NULL); pthread_mutex_init(&lvm_start_mutex, NULL); @@ -577,7 +585,7 @@ /* Don't let anyone else to do work until we are started */ pthread_mutex_lock(&lvm_start_mutex); - pthread_create(&lvm_thread, NULL, lvm_thread_fn, &lvm_params); + pthread_create(&lvm_thread, &stack_attr, lvm_thread_fn, &lvm_params); /* Tell the rest of the cluster our version number */ if (clops->cluster_init_completed) @@ -1355,8 +1363,8 @@ thisfd->bits.localsock.in_progress = TRUE; thisfd->bits.localsock.state = PRE_COMMAND; DEBUGLOG("Creating pre&post thread\n"); - status = pthread_create(&thisfd->bits.localsock.threadid, NULL, - pre_and_post_thread, thisfd); + status = pthread_create(&thisfd->bits.localsock.threadid, + &stack_attr, pre_and_post_thread, thisfd); DEBUGLOG("Created pre&post thread, state = %d\n", status); } return len;
next reply other threads:[~2011-10-11 9:18 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-10-11 9:18 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-27 16:59 mbroz 2012-03-23 9:43 zkabelac 2012-02-28 10:42 zkabelac 2012-02-27 10:17 zkabelac 2012-02-08 13:03 zkabelac 2012-01-26 17:55 zkabelac 2012-01-25 22:36 zkabelac 2011-10-11 10:06 zkabelac 2011-10-11 9:56 zkabelac 2011-10-11 9:23 zkabelac 2011-03-30 12:48 zkabelac 2011-02-28 19:50 zkabelac 2011-01-05 12:17 zkabelac 2010-12-22 14:00 zkabelac 2010-12-20 13:48 zkabelac 2010-11-29 12:44 zkabelac 2010-10-27 11:40 mornfall 2010-10-27 9:13 mornfall 2010-10-26 9:57 zkabelac 2010-10-26 9:01 zkabelac 2009-04-22 10:38 mbroz 2005-08-09 10:39 pcaulfield 2004-09-30 14:16 pcaulfield 2004-09-23 12:51 pcaulfield
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20111011091849.6933.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).