public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/daemons/clvmd clvmd.c Date: Tue, 11 Oct 2011 09:23:00 -0000 [thread overview] Message-ID: <20111011092348.8624.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-10-11 09:23:48 Modified files: daemons/clvmd : clvmd.c Log message: Add FIXMEs for init_test Usage of thread unprotected init_test is not correct and needs probably lvm lock since it part of lvm library. Current implementation may probably fail with test mode and actually create something unexpectedly (and vice versa). Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd.c.diff?cvsroot=lvm2&r1=1.111&r2=1.112 --- LVM2/daemons/clvmd/clvmd.c 2011/10/11 09:18:49 1.111 +++ LVM2/daemons/clvmd/clvmd.c 2011/10/11 09:23:48 1.112 @@ -1514,9 +1514,9 @@ if (replyargs != NULL) { /* Run the command */ - status = - do_command(NULL, msg, msglen, &replyargs, buflen, - &replylen); + /* FIXME: usage of init_test() is unprotected */ + status = do_command(NULL, msg, msglen, &replyargs, + buflen, &replylen); } else { status = ENOMEM; } @@ -1651,6 +1651,7 @@ /* Loop around doing PRE and POST functions until the client goes away */ while (!client->bits.localsock.finished) { /* Execute the code */ + /* FIXME: usage of init_test() is unprotected as in do_command() */ status = do_pre_command(client); if (status) @@ -1733,6 +1734,7 @@ if (replybuf == NULL) return -1; + /* FIXME: usage of init_test() is unprotected */ status = do_command(client, msg, msglen, &replybuf, buflen, &replylen); if (status)
next reply other threads:[~2011-10-11 9:23 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-10-11 9:23 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-27 16:59 mbroz 2012-03-23 9:43 zkabelac 2012-02-28 10:42 zkabelac 2012-02-27 10:17 zkabelac 2012-02-08 13:03 zkabelac 2012-01-26 17:55 zkabelac 2012-01-25 22:36 zkabelac 2011-10-11 10:06 zkabelac 2011-10-11 9:56 zkabelac 2011-10-11 9:18 zkabelac 2011-03-30 12:48 zkabelac 2011-02-28 19:50 zkabelac 2011-01-05 12:17 zkabelac 2010-12-22 14:00 zkabelac 2010-12-20 13:48 zkabelac 2010-11-29 12:44 zkabelac 2010-10-27 11:40 mornfall 2010-10-27 9:13 mornfall 2010-10-26 9:57 zkabelac 2010-10-26 9:01 zkabelac 2009-04-22 10:38 mbroz 2005-08-09 10:39 pcaulfield 2004-09-30 14:16 pcaulfield 2004-09-23 12:51 pcaulfield
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20111011092348.8624.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).