public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2/daemons/clvmd clvmd.c Date: Tue, 11 Oct 2011 09:56:00 -0000 [thread overview] Message-ID: <20111011095645.14339.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-10-11 09:56:45 Modified files: daemons/clvmd : clvmd.c Log message: Add some fixme locking Code here is using thread write protected variable without locking. So add locking, for proper synchronization and a FIXME, since the code needs closer look. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd.c.diff?cvsroot=lvm2&r1=1.114&r2=1.115 --- LVM2/daemons/clvmd/clvmd.c 2011/10/11 09:54:39 1.114 +++ LVM2/daemons/clvmd/clvmd.c 2011/10/11 09:56:44 1.115 @@ -747,12 +747,16 @@ send_local_reply(sock_client, status, sock_client->fd); else { + /* FIXME: closer inspect this code since state is write thread protected */ + pthread_mutex_lock(&sock_client->bits.localsock.mutex); if (sock_client->bits.localsock.state == POST_COMMAND) { + pthread_mutex_unlock(&sock_client->bits.localsock.mutex); send_local_reply(sock_client, 0, sock_client->fd); } else // PRE_COMMAND finished. { + pthread_mutex_unlock(&sock_client->bits.localsock.mutex); if ( (status = distribute_command(sock_client)) !=
next reply other threads:[~2011-10-11 9:56 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-10-11 9:56 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-27 16:59 mbroz 2012-03-23 9:43 zkabelac 2012-02-28 10:42 zkabelac 2012-02-27 10:17 zkabelac 2012-02-08 13:03 zkabelac 2012-01-26 17:55 zkabelac 2012-01-25 22:36 zkabelac 2011-10-11 10:06 zkabelac 2011-10-11 9:23 zkabelac 2011-10-11 9:18 zkabelac 2011-03-30 12:48 zkabelac 2011-02-28 19:50 zkabelac 2011-01-05 12:17 zkabelac 2010-12-22 14:00 zkabelac 2010-12-20 13:48 zkabelac 2010-11-29 12:44 zkabelac 2010-10-27 11:40 mornfall 2010-10-27 9:13 mornfall 2010-10-26 9:57 zkabelac 2010-10-26 9:01 zkabelac 2009-04-22 10:38 mbroz 2005-08-09 10:39 pcaulfield 2004-09-30 14:16 pcaulfield 2004-09-23 12:51 pcaulfield
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20111011095645.14339.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).